This is an automated email from the ASF dual-hosted git repository.
yao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new cbe36b20a85 [SPARK-44801][SQL][FOLLOWUP] Remove overdue comments for
generating plan info in SQLExecution
cbe36b20a85 is described below
commit cbe36b20a85913a37b7f569c3ce7a586eb9cbc89
Author: Kent Yao <[email protected]>
AuthorDate: Wed Sep 6 18:24:12 2023 +0800
[SPARK-44801][SQL][FOLLOWUP] Remove overdue comments for generating plan
info in SQLExecution
### What changes were proposed in this pull request?
This is a followup to clean up comment for generating plan info in
SQLExecution, which is currently wrapped with try-catch block.
### Why are the changes needed?
overdue and misleading comments cleanup
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
existing
### Was this patch authored or co-authored using generative AI tooling?
no
Closes #42825 from yaooqinn/SPARK-44801-F.
Authored-by: Kent Yao <[email protected]>
Signed-off-by: Kent Yao <[email protected]>
---
.../src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala | 2 --
1 file changed, 2 deletions(-)
diff --git
a/sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala
b/sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala
index cd949fb21c9..2a44a016d2d 100644
--- a/sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala
+++ b/sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala
@@ -134,8 +134,6 @@ object SQLExecution extends Logging {
description = desc,
details = callSite.longForm,
physicalPlanDescription =
queryExecution.explainString(planDescriptionMode),
- // `queryExecution.executedPlan` triggers query planning. If it
fails, the exception
- // will be caught and reported in the
`SparkListenerSQLExecutionEnd`
sparkPlanInfo = planInfo,
time = System.currentTimeMillis(),
modifiedConfigs = redactedConfigs,
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
