This is an automated email from the ASF dual-hosted git repository.
gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new c7b20b5dbfb [SPARK-45567][CONNECT] Remove redundant if in
org.apache.spark.sql.connect.execution.ExecuteGrpcResponseSender#run
c7b20b5dbfb is described below
commit c7b20b5dbfbe7eb89f77b3f49854c90b6640a9c3
Author: zhaomin <[email protected]>
AuthorDate: Tue Oct 17 19:31:16 2023 +0900
[SPARK-45567][CONNECT] Remove redundant if in
org.apache.spark.sql.connect.execution.ExecuteGrpcResponseSender#run
### What changes were proposed in this pull request?
remove redundant ```if```
### Why are the changes needed?
it is redundant.
https://issues.apache.org/jira/browse/SPARK-45567?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
pass ci.
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #43395 from zhaomin1423/45567.
Authored-by: zhaomin <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
---
.../spark/sql/connect/execution/ExecuteGrpcResponseSender.scala | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git
a/connector/connect/server/src/main/scala/org/apache/spark/sql/connect/execution/ExecuteGrpcResponseSender.scala
b/connector/connect/server/src/main/scala/org/apache/spark/sql/connect/execution/ExecuteGrpcResponseSender.scala
index ba5ecc7a045..115cedfe112 100644
---
a/connector/connect/server/src/main/scala/org/apache/spark/sql/connect/execution/ExecuteGrpcResponseSender.scala
+++
b/connector/connect/server/src/main/scala/org/apache/spark/sql/connect/execution/ExecuteGrpcResponseSender.scala
@@ -124,11 +124,9 @@ private[connect] class ExecuteGrpcResponseSender[T <:
Message](
execute(lastConsumedStreamIndex)
} finally {
executeHolder.removeGrpcResponseSender(this)
- if (!executeHolder.reattachable) {
- // Non reattachable executions release here immediately.
- // (Reattachable executions release with ReleaseExecute RPC.)
-
SparkConnectService.executionManager.removeExecuteHolder(executeHolder.key)
- }
+ // Non reattachable executions release here immediately.
+ // (Reattachable executions release with ReleaseExecute RPC.)
+
SparkConnectService.executionManager.removeExecuteHolder(executeHolder.key)
}
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
