This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 5384c50dd079 [SPARK-45992][BUILD] Switch from `fgrep` to `grep -F`
5384c50dd079 is described below

commit 5384c50dd079412c404357e2a7faf8de048a21cd
Author: Bjørn Jørgensen <bjornjorgen...@gmail.com>
AuthorDate: Sun Nov 19 12:52:36 2023 -0800

    [SPARK-45992][BUILD] Switch from `fgrep` to `grep -F`
    
    ### What changes were proposed in this pull request?
    Switch from `fgrep` to `grep -F`
    
    ### Why are the changes needed?
    `./dev/make-distribution.sh --name custom-spark --pip -Pkubernetes`
    
    ++ fgrep --count '<id>hive</id>'
    fgrep: warning: fgrep is obsolescent; using grep -F
    
    ### Does this PR introduce _any_ user-facing change?
    No.
    
    ### How was this patch tested?
    
    before
    ++ fgrep --count '<id>hive</id>'
    fgrep: warning: fgrep is obsolescent; using grep -F
    
    After
    Using `mvn` from path: /home/bjorn/spark/build/apache-maven-3.9.5/bin/mvn
    + SPARK_HADOOP_VERSION=3.3.6
    ++ /home/bjorn/spark/build/mvn help:evaluate 
-Dexpression=project.activeProfiles -pl sql/hive -Pkubernetes
    ++ grep -v INFO
    ++ grep -v WARNING
    ++ grep -F --count '<id>hive</id>'
    Using `mvn` from path: /home/bjorn/spark/build/apache-maven-3.9.5/bin/mvn
    ++ echo -n
    
    Pass GA
    
    ### Was this patch authored or co-authored using generative AI tooling?
    No.
    
    Closes #43889 from bjornjorgensen/fgrep-to-grep--F.
    
    Authored-by: Bjørn Jørgensen <bjornjorgen...@gmail.com>
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
 dev/make-distribution.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dev/make-distribution.sh b/dev/make-distribution.sh
index ef7c010e930a..ce5c94197d4a 100755
--- a/dev/make-distribution.sh
+++ b/dev/make-distribution.sh
@@ -141,7 +141,7 @@ SPARK_HADOOP_VERSION=$("$MVN" help:evaluate 
-Dexpression=hadoop.version $@ \
 SPARK_HIVE=$("$MVN" help:evaluate -Dexpression=project.activeProfiles -pl 
sql/hive $@ \
     | grep -v "INFO"\
     | grep -v "WARNING"\
-    | fgrep --count "<id>hive</id>";\
+    | grep -F --count "<id>hive</id>";\
     # Reset exit status to 0, otherwise the script stops here if the last grep 
finds nothing\
     # because we use "set -o pipefail"
     echo -n)


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to