This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 247ce5c8416 [MINOR][TEST] Relax `excludedTpcdsQueries` scope in
`TPCDSBase`
247ce5c8416 is described below
commit 247ce5c841644c7ba5362387103a09fd9b500f76
Author: Liang-Chi Hsieh <[email protected]>
AuthorDate: Tue Nov 21 12:34:51 2023 -0800
[MINOR][TEST] Relax `excludedTpcdsQueries` scope in `TPCDSBase`
### What changes were proposed in this pull request?
This patch relaxes the scope of `excludedTpcdsQueries` in `TPCDSBase` from
`private` to `protected`.
### Why are the changes needed?
When working on TPCDS related tests with `TPCDSBase` or classes
implementing it, sometime we need to exclude some queries. But
`excludedTpcdsQueries` is private so it limits the extensibility.
### Does this PR introduce _any_ user-facing change?
No, this is test only change.
### How was this patch tested?
Existing tests.
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #43943 from viirya/tpcds_minor.
Authored-by: Liang-Chi Hsieh <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
---
sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
b/sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
index 07c24e32000..b6d46d279f4 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala
@@ -34,7 +34,7 @@ trait TPCDSBase extends TPCBase with TPCDSSchema {
"q81", "q82", "q83", "q84", "q85", "q86", "q87", "q88", "q89", "q90",
"q91", "q92", "q93", "q94", "q95", "q96", "q97", "q98", "q99")
- private val excludedTpcdsQueries: Set[String] = if (regenerateGoldenFiles) {
+ protected val excludedTpcdsQueries: Set[String] = if (regenerateGoldenFiles)
{
Set()
} else {
// Since `tpcdsQueriesV2_7_0` has almost the same queries with these ones
below,
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
