This is an automated email from the ASF dual-hosted git repository.

ruifengz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new d1a333d554ad [MINOR][INFRA] Comments in GitHub scripts should start 
with #
d1a333d554ad is described below

commit d1a333d554ad1da59bca277641f9e7d26247a0c6
Author: panbingkun <panbing...@baidu.com>
AuthorDate: Mon Dec 25 19:33:33 2023 +0800

    [MINOR][INFRA] Comments in GitHub scripts should start with #
    
    ### What changes were proposed in this pull request?
    The pr aims to fix a typo in github action script, `comments` in GitHub 
scripts should start with `#`.
    
    ### Why are the changes needed?
    In the GitHub runtime logs, we often observe runtime prompts similar to the 
one below:
    https://github.com/panbingkun/spark/actions/runs/7167111730/job/19513821177
    https://github.com/panbingkun/spark/actions/runs/7167111730/job/19513823103
    <img width="690" alt="image" 
src="https://github.com/apache/spark/assets/15246973/26d39f6c-e6e3-4887-9344-a8fa251a255e";>
    Although it does not affect the overall task execution, I think it is 
necessary to correct it.
    
    ### Does this PR introduce _any_ user-facing change?
    No.
    
    ### How was this patch tested?
    Manually test.
    
    ### Was this patch authored or co-authored using generative AI tooling?
    No.
    
    Closes #44473 from panbingkun/address_github.
    
    Authored-by: panbingkun <panbing...@baidu.com>
    Signed-off-by: Ruifeng Zheng <ruife...@apache.org>
---
 .github/workflows/build_and_test.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build_and_test.yml 
b/.github/workflows/build_and_test.yml
index 2385da332002..a337eaa7864d 100644
--- a/.github/workflows/build_and_test.yml
+++ b/.github/workflows/build_and_test.yml
@@ -264,7 +264,7 @@ jobs:
         export TERM=vt100
         # Hive "other tests" test needs larger metaspace size based on 
experiment.
         if [[ "$MODULES_TO_TEST" == "hive" ]] && [[ "$EXCLUDED_TAGS" == 
"org.apache.spark.tags.SlowHiveTest" ]]; then export METASPACE_SIZE=2g; fi
-        // SPARK-46283: should delete the following env replacement after 
SPARK 3.x EOL
+        # SPARK-46283: should delete the following env replacement after SPARK 
3.x EOL
         if [[ "$MODULES_TO_TEST" == *"streaming-kinesis-asl"* ]] && [[ "${{ 
inputs.branch }}" =~ ^branch-3 ]]; then 
           MODULES_TO_TEST=${MODULES_TO_TEST//streaming-kinesis-asl, /}
         fi


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to