This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new c63dea8f4235 [SPARK-46882][SS][TEST] Replace unnecessary AtomicInteger
with int
c63dea8f4235 is described below
commit c63dea8f42357ecfd4fe41f04732e2cb0d0d53ae
Author: beliefer <[email protected]>
AuthorDate: Wed Jan 31 17:47:50 2024 -0800
[SPARK-46882][SS][TEST] Replace unnecessary AtomicInteger with int
### What changes were proposed in this pull request?
This PR propose to replace unnecessary `AtomicInteger` with int.
### Why are the changes needed?
The variable `value` of `GetMaxCounter` always guarded by itself. So we can
replace the unnecessary `AtomicInteger` with int.
### Does this PR introduce _any_ user-facing change?
'No'.
### How was this patch tested?
GA.
### Was this patch authored or co-authored using generative AI tooling?
'No'.
Closes #44907 from beliefer/SPARK-46882.
Authored-by: beliefer <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
---
.../apache/spark/streaming/util/WriteAheadLogSuite.scala | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git
a/streaming/src/test/scala/org/apache/spark/streaming/util/WriteAheadLogSuite.scala
b/streaming/src/test/scala/org/apache/spark/streaming/util/WriteAheadLogSuite.scala
index 3a9fffec13cf..cf9d5b7387f7 100644
---
a/streaming/src/test/scala/org/apache/spark/streaming/util/WriteAheadLogSuite.scala
+++
b/streaming/src/test/scala/org/apache/spark/streaming/util/WriteAheadLogSuite.scala
@@ -20,7 +20,6 @@ import java.io._
import java.nio.ByteBuffer
import java.util.{Iterator => JIterator}
import java.util.concurrent.{CountDownLatch, RejectedExecutionException,
ThreadPoolExecutor, TimeUnit}
-import java.util.concurrent.atomic.AtomicInteger
import scala.collection.mutable.ArrayBuffer
import scala.concurrent._
@@ -238,14 +237,14 @@ class FileBasedWriteAheadLogSuite
val executionContext = ExecutionContext.fromExecutorService(fpool)
class GetMaxCounter {
- private val value = new AtomicInteger()
- @volatile private var max: Int = 0
+ private var value = 0
+ private var max: Int = 0
def increment(): Unit = synchronized {
- val atInstant = value.incrementAndGet()
- if (atInstant > max) max = atInstant
+ value = value + 1
+ if (value > max) max = value
}
- def decrement(): Unit = synchronized { value.decrementAndGet() }
- def get(): Int = synchronized { value.get() }
+ def decrement(): Unit = synchronized { value = value - 1 }
+ def get(): Int = synchronized { value }
def getMax(): Int = synchronized { max }
}
try {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
