This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new a926c7912a78 [SPARK-47021][BUILD][TESTS] Fix `kvstore` module to have
explicit `commons-lang3` test dependency
a926c7912a78 is described below
commit a926c7912a78f1a2fb71c5ffd21b5c2f723a0128
Author: Dongjoon Hyun <[email protected]>
AuthorDate: Sun Feb 11 10:38:00 2024 -0800
[SPARK-47021][BUILD][TESTS] Fix `kvstore` module to have explicit
`commons-lang3` test dependency
### What changes were proposed in this pull request?
This PR aims to fix `kvstore` module by adding explicit `commons-lang3`
test dependency and excluding `htmlunit-driver` from `org.scalatestplus` to use
Apache Spark's explicit declaration.
https://github.com/apache/spark/blob/fa23d276e7e4ed94bf11d71f2e1daa22fe2238e5/pom.xml#L711-L716
### Why are the changes needed?
Since Spark 3.3.0 (SPARK-37282), `kvstore` uses `commons-lang3` test
dependency like the following, but we didn't declare it explicitly so far.
https://github.com/apache/spark/blob/fa23d276e7e4ed94bf11d71f2e1daa22fe2238e5/common/kvstore/src/test/java/org/apache/spark/util/kvstore/LevelDBSuite.java#L33
https://github.com/apache/spark/blob/fa23d276e7e4ed94bf11d71f2e1daa22fe2238e5/common/kvstore/src/test/java/org/apache/spark/util/kvstore/LevelDBIteratorSuite.java#L23
Previously, it was provided by some unused `htmlunit-driver`'s transitive
dependency accidentally. This causes a weird situation which `kvstore` module
starts to fail to compile when we upgrade `htmlunit-driver`. We need to fix
this first.
```
$ mvn dependency:tree -pl common/kvstore
...
[INFO] | \- org.seleniumhq.selenium:htmlunit-driver:jar:4.12.0:test
...
[INFO] | +- org.apache.commons:commons-lang3:jar:3.14.0:test
```
### Does this PR introduce _any_ user-facing change?
No. This is only a test dependency fix.
### How was this patch tested?
Pass the CIs.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #45080 from dongjoon-hyun/SPARK-47021.
Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
---
common/kvstore/pom.xml | 5 +++++
pom.xml | 6 ++++++
2 files changed, 11 insertions(+)
diff --git a/common/kvstore/pom.xml b/common/kvstore/pom.xml
index a9b5a4634717..3820d1b8e395 100644
--- a/common/kvstore/pom.xml
+++ b/common/kvstore/pom.xml
@@ -70,6 +70,11 @@
<artifactId>commons-io</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-lang3</artifactId>
+ <scope>test</scope>
+ </dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
diff --git a/pom.xml b/pom.xml
index f0eb164d0c45..79d572f1b8bf 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1182,6 +1182,12 @@
<artifactId>selenium-4-12_${scala.binary.version}</artifactId>
<version>3.2.17.0</version>
<scope>test</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>org.seleniumhq.selenium</groupId>
+ <artifactId>htmlunit-driver</artifactId>
+ </exclusion>
+ </exclusions>
</dependency>
<dependency>
<groupId>org.mockito</groupId>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
