This is an automated email from the ASF dual-hosted git repository. dongjoon pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push: new 73da134849b7 [SPARK-47040][CONNECT][FOLLOWUP] Improve usability of the start-conect-server-script.sh 73da134849b7 is described below commit 73da134849b7d2bbd170bb1530dcdf6d5f94f0da Author: Martin Grund <martin.gr...@databricks.com> AuthorDate: Fri Feb 16 09:23:42 2024 -0800 [SPARK-47040][CONNECT][FOLLOWUP] Improve usability of the start-conect-server-script.sh ### What changes were proposed in this pull request? Changes the script to use `SPARK_NO_DAEMONIZE` to start the connect service. ### Why are the changes needed? Ok ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? Manual ### Was this patch authored or co-authored using generative AI tooling? No Closes #45117 from grundprinzip/server_wait_2. Lead-authored-by: Martin Grund <martin.gr...@databricks.com> Co-authored-by: Martin Grund <grundprin...@gmail.com> Signed-off-by: Dongjoon Hyun <dh...@apple.com> --- sbin/start-connect-server.sh | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/sbin/start-connect-server.sh b/sbin/start-connect-server.sh index fecda717eb34..668423bad1cb 100755 --- a/sbin/start-connect-server.sh +++ b/sbin/start-connect-server.sh @@ -30,7 +30,7 @@ fi CLASS="org.apache.spark.sql.connect.service.SparkConnectServer" if [[ "$@" = *--help ]] || [[ "$@" = *-h ]]; then - echo "Usage: ./sbin/start-connect-server.sh [options]" + echo "Usage: ./sbin/start-connect-server.sh [--wait] [options]" "${SPARK_HOME}"/bin/spark-submit --help 2>&1 | grep -v Usage 1>&2 exit 1 @@ -40,8 +40,6 @@ fi if [ "$1" == "--wait" ]; then shift - exec "${SPARK_HOME}"/bin/spark-submit --class $CLASS 1 --name "Spark Connect Server" "$@" -else - exec "${SPARK_HOME}"/sbin/spark-daemon.sh submit $CLASS 1 --name "Spark Connect server" "$@" + export SPARK_NO_DAEMONIZE=1 fi - +exec "${SPARK_HOME}"/sbin/spark-daemon.sh submit $CLASS 1 --name "Spark Connect server" "$@" --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org