This is an automated email from the ASF dual-hosted git repository.
wenchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 6762d1f8beaf [SPARK-47420][SQL] Fix test output
6762d1f8beaf is described below
commit 6762d1f8beafc2ae3a406fa24e62e2b6f93dfdb7
Author: Vladimir Golubev <vladimir.golu...@databricks.com>
AuthorDate: Tue Apr 16 13:50:47 2024 +0800
[SPARK-47420][SQL] Fix test output
Make "AssertionFailedError: expected: <true> but was: <false>" to be
rendered correctly
### What changes were proposed in this pull request?
The assertion was being rendered the other way around
### Why are the changes needed?
To avoid confusion during test checks
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
`testOnly org.apache.spark.unsafe.types.CollationSupportSuite`
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #46058 from vladimirg-db/vladimirg-db/fix-test-output.
Authored-by: Vladimir Golubev <vladimir.golu...@databricks.com>
Signed-off-by: Wenchen Fan <wenc...@databricks.com>
---
.../apache/spark/unsafe/types/CollationSupportSuite.java | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git
a/common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java
b/common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java
index bfb696c35fff..099a13a025e7 100644
---
a/common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java
+++
b/common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java
@@ -30,12 +30,12 @@ public class CollationSupportSuite {
* Collation-aware string expressions.
*/
- private void assertContains(String pattern, String target, String
collationName, boolean value)
+ private void assertContains(String pattern, String target, String
collationName, boolean expected)
throws SparkException {
UTF8String l = UTF8String.fromString(pattern);
UTF8String r = UTF8String.fromString(target);
int collationId = CollationFactory.collationNameToId(collationName);
- assertEquals(CollationSupport.Contains.exec(l, r, collationId), value);
+ assertEquals(expected, CollationSupport.Contains.exec(l, r, collationId));
}
@Test
@@ -103,12 +103,13 @@ public class CollationSupportSuite {
assertContains("äbćδe", "ÄBcΔÉ", "UNICODE_CI", false);
}
- private void assertStartsWith(String pattern, String prefix, String
collationName, boolean value)
+ private void assertStartsWith(
+ String pattern, String prefix, String collationName, boolean
expected)
throws SparkException {
UTF8String l = UTF8String.fromString(pattern);
UTF8String r = UTF8String.fromString(prefix);
int collationId = CollationFactory.collationNameToId(collationName);
- assertEquals(CollationSupport.StartsWith.exec(l, r, collationId), value);
+ assertEquals(expected, CollationSupport.StartsWith.exec(l, r,
collationId));
}
@Test
@@ -176,12 +177,12 @@ public class CollationSupportSuite {
assertStartsWith("äbćδe", "ÄBcΔÉ", "UNICODE_CI", false);
}
- private void assertEndsWith(String pattern, String suffix, String
collationName, boolean value)
+ private void assertEndsWith(String pattern, String suffix, String
collationName, boolean expected)
throws SparkException {
UTF8String l = UTF8String.fromString(pattern);
UTF8String r = UTF8String.fromString(suffix);
int collationId = CollationFactory.collationNameToId(collationName);
- assertEquals(CollationSupport.EndsWith.exec(l, r, collationId), value);
+ assertEquals(expected, CollationSupport.EndsWith.exec(l, r, collationId));
}
@Test
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
