This is an automated email from the ASF dual-hosted git repository.
gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 69f3a9b969f3 [SPARK-48586][SS][FOLLOWUP] RocksDB and
RocksDBFileManager code style changes
69f3a9b969f3 is described below
commit 69f3a9b969f3d0949391575c26c7a127a7afb37b
Author: Riya Verma <[email protected]>
AuthorDate: Fri Jun 28 14:44:17 2024 +0900
[SPARK-48586][SS][FOLLOWUP] RocksDB and RocksDBFileManager code style
changes
### What changes were proposed in this pull request?
This is a follow up PR to #46942 addressing the style changes that were
requested.
### Why are the changes needed?
Style changes added.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Not applicable.
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #47136 from riyaverm-db/rocks-db-style.
Authored-by: Riya Verma <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
---
.../apache/spark/sql/execution/streaming/state/RocksDB.scala | 8 ++++----
.../sql/execution/streaming/state/RocksDBFileManager.scala | 12 ++++++------
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git
a/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala
b/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala
index e1b6e34639a0..798311d99ba3 100644
---
a/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala
+++
b/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala
@@ -75,10 +75,10 @@ class RocksDB(
useColumnFamilies: Boolean = false) extends Logging {
case class RocksDBSnapshot(
- checkpointDir: File,
- version: Long,
- numKeys: Long,
- capturedFileMappings: RocksDBFileMappings) {
+ checkpointDir: File,
+ version: Long,
+ numKeys: Long,
+ capturedFileMappings: RocksDBFileMappings) {
def close(): Unit = {
silentDeleteRecursively(checkpointDir, s"Free up local checkpoint of
snapshot $version")
}
diff --git
a/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala
b/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala
index dec28ef50eae..fe7aeeb6fd3f 100644
---
a/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala
+++
b/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala
@@ -218,10 +218,10 @@ class RocksDBFileManager(
/** Save all the files in given local checkpoint directory as a committed
version in DFS */
def saveCheckpointToDfs(
- checkpointDir: File,
- version: Long,
- numKeys: Long,
- capturedFileMappings: RocksDBFileMappings): Unit = {
+ checkpointDir: File,
+ version: Long,
+ numKeys: Long,
+ capturedFileMappings: RocksDBFileMappings): Unit = {
logFilesInDir(checkpointDir, log"Saving checkpoint files " +
log"for version ${MDC(LogKeys.VERSION_NUM, version)}")
val (localImmutableFiles, localOtherFiles) =
listRocksDBFiles(checkpointDir)
@@ -779,8 +779,8 @@ class RocksDBFileManager(
*/
case class RocksDBFileMappings(
- versionToRocksDBFiles: ConcurrentHashMap[Long, Seq[RocksDBImmutableFile]],
- localFilesToDfsFiles: ConcurrentHashMap[String, RocksDBImmutableFile])
+ versionToRocksDBFiles: ConcurrentHashMap[Long, Seq[RocksDBImmutableFile]],
+ localFilesToDfsFiles: ConcurrentHashMap[String, RocksDBImmutableFile])
/**
* Metrics regarding RocksDB file sync between local and DFS.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
