This is an automated email from the ASF dual-hosted git repository.
yangjie01 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new abf9bac69680 [SPARK-49076][SQL] Fix the outdated `logical plan name`
in `AstBuilder's` comments
abf9bac69680 is described below
commit abf9bac696804d7af28fbc9cd9026efddea303e3
Author: panbingkun <[email protected]>
AuthorDate: Thu Aug 1 23:32:44 2024 +0800
[SPARK-49076][SQL] Fix the outdated `logical plan name` in `AstBuilder's`
comments
### What changes were proposed in this pull request?
The pr aims to fix the outdated `logical plan name` in `AstBuilder's`
comments.
### Why are the changes needed?
- After the pr https://github.com/apache/spark/pull/33609, the name of the
logical plan below has been changed:
`AlterTableAddColumns` -> `AddColumns`
`AlterTableRenameColumn` -> `RenameColumn`
`AlterTableAlterColumn` -> `AlterColumn`
`AlterTableDropColumns` -> `DropColumns`
- After the pr https://github.com/apache/spark/pull/30398
The name of the logical plan `ShowPartitionsStatement` has been changed to
`ShowPartitions`.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Only update comments.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #47562 from panbingkun/fix_astbuilder.
Lead-authored-by: panbingkun <[email protected]>
Co-authored-by: panbingkun <[email protected]>
Signed-off-by: yangjie01 <[email protected]>
---
.../apache/spark/sql/catalyst/parser/AstBuilder.scala | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
index a046ededf964..feb3ef4e7155 100644
---
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
+++
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
@@ -61,8 +61,8 @@ import org.apache.spark.util.random.RandomSampler
* The AstBuilder converts an ANTLR4 ParseTree into a catalyst Expression,
LogicalPlan or
* TableIdentifier.
*/
-class AstBuilder extends DataTypeAstBuilder with SQLConfHelper
- with Logging with DataTypeErrorsBase {
+class AstBuilder extends DataTypeAstBuilder
+ with SQLConfHelper with Logging with DataTypeErrorsBase {
import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._
import ParserUtils._
@@ -4452,7 +4452,7 @@ class AstBuilder extends DataTypeAstBuilder with
SQLConfHelper
}
/**
- * Parse a [[AlterTableAddColumns]] command.
+ * Parse a [[AddColumns]] command.
*
* For example:
* {{{
@@ -4469,7 +4469,7 @@ class AstBuilder extends DataTypeAstBuilder with
SQLConfHelper
}
/**
- * Parse a [[AlterTableRenameColumn]] command.
+ * Parse a [[RenameColumn]] command.
*
* For example:
* {{{
@@ -4485,7 +4485,7 @@ class AstBuilder extends DataTypeAstBuilder with
SQLConfHelper
}
/**
- * Parse a [[AlterTableAlterColumn]] command to alter a column's property.
+ * Parse a [[AlterColumn]] command to alter a column's property.
*
* For example:
* {{{
@@ -4555,7 +4555,7 @@ class AstBuilder extends DataTypeAstBuilder with
SQLConfHelper
}
/**
- * Parse a [[AlterTableAlterColumn]] command. This is Hive SQL syntax.
+ * Parse a [[AlterColumn]] command. This is Hive SQL syntax.
*
* For example:
* {{{
@@ -4639,7 +4639,7 @@ class AstBuilder extends DataTypeAstBuilder with
SQLConfHelper
}
/**
- * Parse a [[AlterTableDropColumns]] command.
+ * Parse a [[DropColumns]] command.
*
* For example:
* {{{
@@ -4979,7 +4979,7 @@ class AstBuilder extends DataTypeAstBuilder with
SQLConfHelper
* A command for users to list the partition names of a table. If partition
spec is specified,
* partitions that match the spec are returned. Otherwise an empty result
set is returned.
*
- * This function creates a [[ShowPartitionsStatement]] logical plan
+ * This function creates a [[ShowPartitions]] logical plan
*
* The syntax of using this command in SQL is:
* {{{
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
