This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/spark-kubernetes-operator.git


The following commit(s) were added to refs/heads/main by this push:
     new 2317d13  [SPARK-49289] Fix `docker-entrypoint.sh` to quote the 
environment variables
2317d13 is described below

commit 2317d13a51b824c7e48b575dc3bacf32d10918f2
Author: Dongjoon Hyun <[email protected]>
AuthorDate: Sun Aug 18 16:33:02 2024 -0700

    [SPARK-49289] Fix `docker-entrypoint.sh` to quote the environment variables
    
    ### What changes were proposed in this pull request?
    
    This PR aims to fix `docker-entrypoint.sh` to quote the environment 
variables.
    
    ### Why are the changes needed?
    
    To protect Spark Operator by preventing any potential misuse of  
`OPERATOR_JAVA_OPTS` or `LOG_CONFIG` variables
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    Manual review.
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    No.
    
    Closes #60 from dongjoon-hyun/SPARK-49289.
    
    Authored-by: Dongjoon Hyun <[email protected]>
    Signed-off-by: Dongjoon Hyun <[email protected]>
---
 build-tools/docker/docker-entrypoint.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/build-tools/docker/docker-entrypoint.sh 
b/build-tools/docker/docker-entrypoint.sh
index 1f28239..7552ee8 100755
--- a/build-tools/docker/docker-entrypoint.sh
+++ b/build-tools/docker/docker-entrypoint.sh
@@ -26,7 +26,7 @@ if [ "$1" = "help" ]; then
 elif [ "$1" = "operator" ]; then
   echo "Starting Operator..."
 
-  exec java -cp "./$OPERATOR_JAR" $LOG_CONFIG $OPERATOR_JAVA_OPTS 
org.apache.spark.k8s.operator.SparkOperator
+  exec java -cp "./$OPERATOR_JAR" "$LOG_CONFIG" "$OPERATOR_JAVA_OPTS" 
org.apache.spark.k8s.operator.SparkOperator
 fi
 
 args=("${args[@]}")


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to