This is an automated email from the ASF dual-hosted git repository.

yangjie01 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new effcf22a029f [SPARK-49457][BUILD] Remove uncommon curl option 
`--retry-all-errors`
effcf22a029f is described below

commit effcf22a029f2f61aa2513ae06554d171a774f5b
Author: Cheng Pan <[email protected]>
AuthorDate: Thu Aug 29 22:55:08 2024 +0800

    [SPARK-49457][BUILD] Remove uncommon curl option `--retry-all-errors`
    
    ### What changes were proposed in this pull request?
    
    Remove uncommon curl option `--retry-all-errors`, which is added in curl 
7.71.0 - June 24 2020, old versions can not recognize this option.
    
    ### Why are the changes needed?
    
    It causes `build/mvn` to fail on Ubuntu 20.04.
    
    ```
    exec: curl --retry 3 --retry-all-errors --silent --show-error -L 
https://www.apache.org/dyn/closer.lua/maven/maven-3/3.9.9/binaries/apache-maven-3.9.9-bin.tar.gz?action=download
    curl: option --retry-all-errors: is unknown
    curl: try 'curl --help' or 'curl --manual' for more information
    ```
    
    ```
    $ curl --version
    curl 7.68.0 (aarch64-unknown-linux-gnu) libcurl/7.68.0 OpenSSL/1.1.1f 
zlib/1.2.11 brotli/1.0.7 libidn2/2.2.0 libpsl/0.21.0 (+libidn2/2.2.0) 
libssh/0.9.3/openssl/zlib nghttp2/1.40.0 librtmp/2.3
    Release-Date: 2020-01-08
    Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 
pop3s rtmp rtsp scp sftp smb smbs smtp smtps telnet tftp
    Features: AsynchDNS brotli GSS-API HTTP2 HTTPS-proxy IDN IPv6 Kerberos 
Largefile libz NTLM NTLM_WB PSL SPNEGO SSL TLS-SRP UnixSockets
    ```
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    Manually test.
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    No.
    
    Closes #47926 from pan3793/SPARK-49457.
    
    Authored-by: Cheng Pan <[email protected]>
    Signed-off-by: yangjie01 <[email protected]>
---
 build/mvn | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/build/mvn b/build/mvn
index 28454c68fd12..060209ac1ac4 100755
--- a/build/mvn
+++ b/build/mvn
@@ -58,7 +58,7 @@ install_app() {
   local local_checksum="${local_tarball}.${checksum_suffix}"
   local 
remote_checksum="https://archive.apache.org/dist/${url_path}.${checksum_suffix}";
 
-  local curl_opts="--retry 3 --retry-all-errors --silent --show-error -L"
+  local curl_opts="--retry 3 --silent --show-error -L"
   local wget_opts="--no-verbose"
 
   if [ ! -f "$binary" ]; then


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to