This is an automated email from the ASF dual-hosted git repository.
maxgekk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new dd8d1270679c [SPARK-49650][SQL][DOCS] Updates references to deprecated
Hive JDBC client params in tests and docs
dd8d1270679c is described below
commit dd8d1270679ce6cc99c217eca7e5ecba463fd7ab
Author: Josh Rosen <[email protected]>
AuthorDate: Tue Sep 17 09:17:45 2024 +0200
[SPARK-49650][SQL][DOCS] Updates references to deprecated Hive JDBC client
params in tests and docs
### What changes were proposed in this pull request?
This PR updates unit tests and docs to update references to long-deprecated
Hive JDBC client connection string parameters.
The current docs and some test code are using parameters that have been
deprecated for nearly a decade since
https://issues.apache.org/jira/browse/HIVE-6972 /
https://github.com/apache/hive/commit/07082e8a851cb44a95dcae50bc84fb43cb1e84c6
, so I think it's safe to clean up the usages now.
### Why are the changes needed?
While looking at some hive-thriftserver unit tests logs, I saw repeated
spam of
```
20/06/05 06:35:55.442 pool-1-thread-1 WARN Utils: ***** JDBC param
deprecation *****
20/06/05 06:35:55.442 pool-1-thread-1 WARN Utils: The use of
hive.server2.transport.mode is deprecated.
20/06/05 06:35:55.442 pool-1-thread-1 WARN Utils: Please use transportMode
like so: jdbc:hive2://<host>:<port>/dbName;transportMode=<transport_mode_value>
20/06/05 06:35:55.442 pool-1-thread-1 WARN Utils: ***** JDBC param
deprecation *****
20/06/05 06:35:55.442 pool-1-thread-1 WARN Utils: The use of
hive.server2.thrift.http.path is deprecated.
20/06/05 06:35:55.442 pool-1-thread-1 WARN Utils: Please use httpPath like
so: jdbc:hive2://<host>:<port>/dbName;httpPath=<http_path_value>
```
### Does this PR introduce _any_ user-facing change?
No, it's just a test + documentation change, recommending syntax which has
been long-supported (some tests were [already using the new
parameters](https://github.com/apache/spark/blob/d3eb99f79e508d62fdb7e9bc595f0240ac021df5/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SharedThriftServer.scala#L81-L85)).
### How was this patch tested?
Existing tests (let's wait to confirm that they pass in CI).
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #48114 from JoshRosen/avoid-using-deprecated-hive-params.
Lead-authored-by: Josh Rosen <[email protected]>
Co-authored-by: Josh Rosen <[email protected]>
Signed-off-by: Max Gekk <[email protected]>
---
docs/sql-distributed-sql-engine.md | 4 ++--
.../spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/docs/sql-distributed-sql-engine.md
b/docs/sql-distributed-sql-engine.md
index 734723f8c623..ae8fd9c7211b 100644
--- a/docs/sql-distributed-sql-engine.md
+++ b/docs/sql-distributed-sql-engine.md
@@ -83,7 +83,7 @@ Use the following setting to enable HTTP mode as system
property or in `hive-sit
To test, use beeline to connect to the JDBC/ODBC server in http mode with:
- beeline> !connect
jdbc:hive2://<host>:<port>/<database>?hive.server2.transport.mode=http;hive.server2.thrift.http.path=<http_endpoint>
+ beeline> !connect
jdbc:hive2://<host>:<port>/<database>;transportMode=http;httpPath=<http_endpoint>
If you closed a session and do CTAS, you must set `fs.%s.impl.disable.cache`
to true in `hive-site.xml`.
See more details in
[[SPARK-21067]](https://issues.apache.org/jira/browse/SPARK-21067).
@@ -94,4 +94,4 @@ To use the Spark SQL command line interface (CLI) from the
shell:
./bin/spark-sql
-For details, please refer to [Spark SQL
CLI](sql-distributed-sql-engine-spark-sql-cli.html)
\ No newline at end of file
+For details, please refer to [Spark SQL
CLI](sql-distributed-sql-engine-spark-sql-cli.html)
diff --git
a/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
b/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
index 3ccbd23b71c9..4575549005f3 100644
---
a/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
+++
b/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
@@ -1430,9 +1430,9 @@ abstract class HiveThriftServer2TestBase extends
SparkFunSuite with BeforeAndAft
protected def jdbcUri(database: String = "default"): String = if (mode ==
ServerMode.http) {
s"""jdbc:hive2://$localhost:$serverPort/
- |$database?
- |hive.server2.transport.mode=http;
- |hive.server2.thrift.http.path=cliservice;
+ |$database;
+ |transportMode=http;
+ |httpPath=cliservice;?
|${hiveConfList}#${hiveVarList}
""".stripMargin.split("\n").mkString.trim
} else {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
