This is an automated email from the ASF dual-hosted git repository.
yangjie01 pushed a commit to branch branch-3.5
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-3.5 by this push:
new 153cd9e1a796 [SPARK-50492][SS][FOLLOWUP][3.5] Change `def references`
to `lazy val references` in `DeduplicateWithinWatermark` to fix the compilation
issue
153cd9e1a796 is described below
commit 153cd9e1a79643c88d5b26e6fae0086a472380f8
Author: yangjie01 <[email protected]>
AuthorDate: Fri Dec 6 16:36:11 2024 +0800
[SPARK-50492][SS][FOLLOWUP][3.5] Change `def references` to `lazy val
references` in `DeduplicateWithinWatermark` to fix the compilation issue
### What changes were proposed in this pull request?
This pr change `def references` to `lazy val references` in
`DeduplicateWithinWatermark` to fix the following compilation error：
- https://github.com/apache/spark/actions/runs/12191807324/job/34011354774
```
[error]
/home/runner/work/spark/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala:1948:16:
overriding lazy value references in class QueryPlan of type
org.apache.spark.sql.catalyst.expressions.AttributeSet;
[error] method references needs to be a stable, immutable value
[error] override def references: AttributeSet = AttributeSet(keys) ++
[error] ^
[error] one error found
```
### Why are the changes needed?
Fix compile error.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass GitHub Actions
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #49087 from LuciferYang/SPARK-50492-FOLLOWUP-3.5.
Authored-by: yangjie01 <[email protected]>
Signed-off-by: yangjie01 <[email protected]>
---
.../spark/sql/catalyst/plans/logical/basicLogicalOperators.scala | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
index b2ae138a9b0a..4824bc1f3c26 100644
---
a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
+++
b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
@@ -1945,7 +1945,8 @@ case class Deduplicate(
case class DeduplicateWithinWatermark(keys: Seq[Attribute], child:
LogicalPlan) extends UnaryNode {
// Ensure that references include event time columns so they are not pruned
away.
- override def references: AttributeSet = AttributeSet(keys) ++
+ @transient
+ override lazy val references: AttributeSet = AttributeSet(keys) ++
AttributeSet(child.output.filter(_.metadata.contains(EventTimeWatermark.delayKey)))
override def maxRows: Option[Long] = child.maxRows
override def output: Seq[Attribute] = child.output
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
