This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 96da1abc0f3a [MINOR] Remove TODO comment about `ExecutorAdded` message
96da1abc0f3a is described below
commit 96da1abc0f3a89470358445b2fa89f6ab9726983
Author: Dongjoon Hyun <[email protected]>
AuthorDate: Tue Jan 7 16:43:33 2025 -0800
[MINOR] Remove TODO comment about `ExecutorAdded` message
### What changes were proposed in this pull request?
This PR aims to remove `TODO` comment about `ExecutorAdded` message.
```
// TODO(matei): replace hostPort with host
```
### Why are the changes needed?
`ExecutorAdded` message has been stable over 12 years with no change.
It's unlikely for us to change this in Spark 4 or in the future.
Thus, we had better remove this TODO message from Spark 4.
### Does this PR introduce _any_ user-facing change?
No, this is a comment removal.
### How was this patch tested?
Manual review.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #49402 from dongjoon-hyun/todo.
Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
---
core/src/main/scala/org/apache/spark/deploy/DeployMessage.scala | 1 -
1 file changed, 1 deletion(-)
diff --git a/core/src/main/scala/org/apache/spark/deploy/DeployMessage.scala
b/core/src/main/scala/org/apache/spark/deploy/DeployMessage.scala
index cb5996a5097d..12e031711aa2 100644
--- a/core/src/main/scala/org/apache/spark/deploy/DeployMessage.scala
+++ b/core/src/main/scala/org/apache/spark/deploy/DeployMessage.scala
@@ -205,7 +205,6 @@ private[deploy] object DeployMessages {
case class RegisteredApplication(appId: String, master: RpcEndpointRef)
extends DeployMessage
- // TODO(matei): replace hostPort with host
case class ExecutorAdded(id: Int, workerId: String, hostPort: String, cores:
Int, memory: Int) {
Utils.checkHostPort(hostPort)
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
