This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-3.5
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-3.5 by this push:
new eedb1aafb26e [SPARK-48899][K8S] Fix `ENV` key value format in K8s
Dockerfiles
eedb1aafb26e is described below
commit eedb1aafb26e4000c73b84e6d3171822baa445af
Author: Dongjoon Hyun <[email protected]>
AuthorDate: Mon Jul 15 13:11:06 2024 -0700
[SPARK-48899][K8S] Fix `ENV` key value format in K8s Dockerfiles
### What changes were proposed in this pull request?
This PR aims to fix `ENV` key value format in K8s Dockerfiles.
### Why are the changes needed?
To follow the Docker guideline to fix the following legacy format.
- https://docs.docker.com/reference/build-checks/legacy-key-value-format/
```
- LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy
"ENV key value" format
```
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the CIs.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #47357 from dongjoon-hyun/SPARK-48899.
Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 40899c1aca543ab25f7de0992e242debf961de56)
Signed-off-by: Dongjoon Hyun <[email protected]>
---
.../kubernetes/docker/src/main/dockerfiles/spark/Dockerfile | 2 +-
.../kubernetes/docker/src/main/dockerfiles/spark/bindings/R/Dockerfile | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
a/resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile
b/resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile
index c30823de0136..f44f13df2984 100644
--- a/resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile
+++ b/resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile
@@ -52,7 +52,7 @@ COPY examples /opt/spark/examples
COPY kubernetes/tests /opt/spark/tests
COPY data /opt/spark/data
-ENV SPARK_HOME /opt/spark
+ENV SPARK_HOME=/opt/spark
WORKDIR /opt/spark/work-dir
RUN chmod g+w /opt/spark/work-dir
diff --git
a/resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/R/Dockerfile
b/resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/R/Dockerfile
index 3a5b96dc12be..d8d9b1aebaa1 100644
---
a/resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/R/Dockerfile
+++
b/resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/R/Dockerfile
@@ -32,7 +32,7 @@ RUN \
rm -rf /var/cache/apt/* && rm -rf /var/lib/apt/lists/*
COPY R ${SPARK_HOME}/R
-ENV R_HOME /usr/lib/R
+ENV R_HOME=/usr/lib/R
WORKDIR /opt/spark/work-dir
ENTRYPOINT [ "/opt/entrypoint.sh" ]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
