raboof commented on code in PR #590:
URL: https://github.com/apache/spark-website/pull/590#discussion_r2014364030
##########
_layouts/global.html:
##########
@@ -147,7 +147,6 @@
<li><a class="dropdown-item"
href="https://www.apache.org/foundation/sponsorship.html";>Sponsorship</a></li>
<li><a class="dropdown-item"
href="https://www.apache.org/foundation/thanks.html";>Thanks</a></li>
- <li><a class="dropdown-item"
href="https://www.apache.org/security/";>Security</a></li>
Review Comment:
I had assumed the Security link in the Developers menu would _already_
satisfy the ASF website check - but indeed I see the ASF website check
(https://whimsy.apache.org/site/check/security) seems to want an absolute link
to an apache.org site, while the Security link in the Developers menu is a
relative link.
I guess we could fix this either on the spark-website side by replacing
`{{site.baseurl}}` with `{{site.url}}{{site.baseurl}}` (see e.g.
https://mademistakes.com/mastering-jekyll/site-url-baseurl/), or try to change
the regex to also allow relative links.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
