This is an automated email from the ASF dual-hosted git repository.
yao pushed a commit to branch branch-4.0
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-4.0 by this push:
new a5f1bb0c95a7 [SPARK-51860][CONNECT] Disable
`spark.connect.grpc.debug.enabled` by default
a5f1bb0c95a7 is described below
commit a5f1bb0c95a7afab5a1856c977131e6aae2b6bc6
Author: Dongjoon Hyun <dongj...@apache.org>
AuthorDate: Tue Apr 22 11:48:44 2025 +0800
[SPARK-51860][CONNECT] Disable `spark.connect.grpc.debug.enabled` by default
### What changes were proposed in this pull request?
This PR aims to disable `spark.connect.grpc.debug.enabled` by default.
### Why are the changes needed?
While checking `Spark Connect` feature of Apache Spark 4.0.0 RC4, I found
that Apache Spark 4.0.0 has `spark.connect.grpc.debug.enabled=true` by default.
We had better disable it by default from Apache Spark 4.0.0.
### Does this PR introduce _any_ user-facing change?
No behavior change from user perspective.
### How was this patch tested?
Pass the CIs.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #50655 from dongjoon-hyun/SPARK-51860.
Authored-by: Dongjoon Hyun <dongj...@apache.org>
Signed-off-by: Kent Yao <y...@apache.org>
(cherry picked from commit a6f842624e746087875991fc1b335bdba3f6d031)
Signed-off-by: Kent Yao <y...@apache.org>
---
.../org/apache/spark/sql/connect/service/SparkConnectService.scala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/sql/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala
b/sql/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala
index 8fa64ddcce49..aab338cc06ff 100644
---
a/sql/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala
+++
b/sql/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala
@@ -363,7 +363,7 @@ object SparkConnectService extends Logging {
* Starts the GRPC Service.
*/
private def startGRPCService(): Unit = {
- val debugMode =
SparkEnv.get.conf.getBoolean("spark.connect.grpc.debug.enabled", true)
+ val debugMode =
SparkEnv.get.conf.getBoolean("spark.connect.grpc.debug.enabled", false)
val bindAddress = SparkEnv.get.conf.get(CONNECT_GRPC_BINDING_ADDRESS)
val startPort = SparkEnv.get.conf.get(CONNECT_GRPC_BINDING_PORT)
val sparkConnectService = new SparkConnectService(debugMode)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
