This is an automated email from the ASF dual-hosted git repository.
mgrund pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark-connect-go.git
The following commit(s) were added to refs/heads/master by this push:
new a530ab2 [MINOR] Fix build without generating protos
a530ab2 is described below
commit a530ab214c1603dcbb036d8248186f854e0dad14
Author: Martin Grund <martin.gr...@databricks.com>
AuthorDate: Mon Jun 9 09:34:10 2025 -0700
[MINOR] Fix build without generating protos
### What changes were proposed in this pull request?
Updating the build to avoid regenerating the proto for a build without using
### Why are the changes needed?
Build
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Manual
Closes #145 from grundprinzip/rc-build.
Authored-by: Martin Grund <martin.gr...@databricks.com>
Signed-off-by: Martin Grund <martin.gr...@databricks.com>
---
Makefile | 13 ++++++++-----
NOTICE | 5 +++++
README.md | 10 ++++++++++
spark/version.go | 2 +-
4 files changed, 24 insertions(+), 6 deletions(-)
diff --git a/Makefile b/Makefile
index 0efb305..0836265 100644
--- a/Makefile
+++ b/Makefile
@@ -52,7 +52,7 @@ OK := $(shell tput setaf 6; echo ' [OK]'; tput sgr0;)
all: build
-build: $(BUILD_OUTPUT) $(BINARIES) # internal/generated.out
+build: $(BUILD_OUTPUT) $(BINARIES)
cmd/spark-connect-example-raw-grpc-client/spark-connect-example-raw-grpc-client:
$(GOFILES_BUILD)
@echo ">> BUILD, output = $@"
@@ -72,8 +72,7 @@ internal/generated.out:
gen: internal/generated.out
-# Remove dependency on gen until Spark 4 has the fix for the pipelines.proto
-$(GOFILES_BUILD): #gen
+$(GOFILES_BUILD):
$(BUILD_OUTPUT): $(GOFILES_BUILD)
@echo -n ">> BUILD, output = $@"
@@ -111,10 +110,14 @@ check:
clean:
@echo -n ">> CLEAN"
@$(GO) clean -i ./...
- @rm -rf ./internal/generated
- @rm -f ./internal/generated.out
@rm -f ./coverage-all.html
@rm -f ./coverage-all.out
@rm -f ./coverage.out
@find . -type f -name "coverage.out" -delete
@printf '%s\n' '$(OK)'
+
+cleangen:
+ @rm -rf ./internal/generated
+ @rm -f ./internal/generated.out
+
+cleanall: clean cleangen
\ No newline at end of file
diff --git a/NOTICE b/NOTICE
new file mode 100644
index 0000000..d19bcf0
--- /dev/null
+++ b/NOTICE
@@ -0,0 +1,5 @@
+Apache Spark
+Copyright 2014 and onwards The Apache Software Foundation.
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
\ No newline at end of file
diff --git a/README.md b/README.md
index 63decd1..51d674f 100644
--- a/README.md
+++ b/README.md
@@ -21,11 +21,21 @@ Step 2: Ensure you have installed `buf CLI` installed,
[more info here](https://
Step 3: Run the following commands to setup the Spark Connect client.
+Building with Spark in case you need to re-generate the source files from the
proto sources.
+
```
git clone https://github.com/apache/spark-connect-go.git
git submodule update --init --recursive
make gen && make test
+
+```
+
+Building without Spark
+
+```
+git clone https://github.com/apache/spark-connect-go.git
+make && make test
```
Step 4: Setup the Spark Driver on localhost.
diff --git a/spark/version.go b/spark/version.go
index 8386b5e..85bfc2d 100644
--- a/spark/version.go
+++ b/spark/version.go
@@ -16,5 +16,5 @@
package spark
func Version() string {
- return "3.5.x"
+ return "4.0.0"
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
