This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-4.0
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-4.0 by this push:
new bd0b9a133d88 [MINOR][CORE] Remove a wrong comment inside
`SparkTestUtils.SparkTestUtils`
bd0b9a133d88 is described below
commit bd0b9a133d88ec2ddf0f709b14744069fcaa1536
Author: Dongjoon Hyun <dongj...@apache.org>
AuthorDate: Wed Aug 6 19:25:30 2025 -0700
[MINOR][CORE] Remove a wrong comment inside `SparkTestUtils.SparkTestUtils`
### What changes were proposed in this pull request?
This PR aims to remove a wrong comment of `SparkTestUtils` to match with
the real logic.
### Why are the changes needed?
`SparkTestUtils` imports `java.nio.file.Files` and uses `Files.move`
supporting copy-based move between different file systems. So, `SparkTestUtils`
doesn't use Google's `Files.move`.
https://github.com/apache/spark/blob/111c7c6d9ff3fdebcc2e43affc5207a1c8e97ffe/common/utils/src/main/scala/org/apache/spark/util/SparkTestUtils.scala#L22
https://github.com/apache/spark/blob/111c7c6d9ff3fdebcc2e43affc5207a1c8e97ffe/common/utils/src/main/scala/org/apache/spark/util/SparkTestUtils.scala#L69-L71
### Does this PR introduce _any_ user-facing change?
No, this is a comment removal.
### How was this patch tested?
Manual review.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #51889 from dongjoon-hyun/minor_SparkTestUtils.
Authored-by: Dongjoon Hyun <dongj...@apache.org>
Signed-off-by: Dongjoon Hyun <dongj...@apache.org>
(cherry picked from commit e4ded081011938b90b9f0c332b0a427e738147bc)
Signed-off-by: Dongjoon Hyun <dongj...@apache.org>
---
common/utils/src/main/scala/org/apache/spark/util/SparkTestUtils.scala | 2 --
1 file changed, 2 deletions(-)
diff --git
a/common/utils/src/main/scala/org/apache/spark/util/SparkTestUtils.scala
b/common/utils/src/main/scala/org/apache/spark/util/SparkTestUtils.scala
index 34b40a5a8890..83028ad06a8f 100644
--- a/common/utils/src/main/scala/org/apache/spark/util/SparkTestUtils.scala
+++ b/common/utils/src/main/scala/org/apache/spark/util/SparkTestUtils.scala
@@ -66,8 +66,6 @@ private[spark] trait SparkTestUtils {
assert(result.exists(), "Compiled file not found: " +
result.getAbsolutePath())
val out = new File(destDir, fileName)
- // renameTo cannot handle in and out files in different filesystems
- // use google's Files.move instead
Files.move(result.toPath, out.toPath)
assert(out.exists(), "Destination file not moved: " +
out.getAbsolutePath())
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
