This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 7781ec2d5086 [SPARK-53600][SQL] Revise `SessionHolder` last access
time log message
7781ec2d5086 is described below
commit 7781ec2d5086c0dfe7593b6145446a28ecc4fd13
Author: Dongjoon Hyun <dongj...@apache.org>
AuthorDate: Tue Sep 16 15:07:23 2025 -0700
[SPARK-53600][SQL] Revise `SessionHolder` last access time log message
### What changes were proposed in this pull request?
This PR aims to revise `SessionHolder` last access time log message.
### Why are the changes needed?
To be clear that it's the last access time (timestamp) instead of durations.
**BEFORE**
```
Session with userId: dongjoon and sessionId: *<id>* accessed,time
1758044807121 ms.
```
**AFTER**
```
Session with userId: dongjoon and sessionId: *<id>* accessed at timestamp
1758044739284.
```
### Does this PR introduce _any_ user-facing change?
No behavior change.
### How was this patch tested?
Manual review.
```
$ sbin/start-connect-server.sh --wait
```
```
$ bin/spark-connect-shell --remote sc://localhost:15002
```
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #52357 from dongjoon-hyun/SPARK-53600.
Authored-by: Dongjoon Hyun <dongj...@apache.org>
Signed-off-by: Dongjoon Hyun <dongj...@apache.org>
---
.../scala/org/apache/spark/sql/connect/service/SessionHolder.scala | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/sql/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SessionHolder.scala
b/sql/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SessionHolder.scala
index be59439daefb..93512a36552e 100644
---
a/sql/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SessionHolder.scala
+++
b/sql/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SessionHolder.scala
@@ -262,8 +262,8 @@ case class SessionHolder(userId: String, sessionId: String,
session: SparkSessio
lastAccessTimeMs = System.currentTimeMillis()
logInfo(
log"Session with userId: ${MDC(LogKeys.USER_ID, userId)} and " +
- log"sessionId: ${MDC(LogKeys.SESSION_ID, sessionId)} accessed," +
- log"time ${MDC(LogKeys.LAST_ACCESS_TIME, lastAccessTimeMs)} ms.")
+ log"sessionId: ${MDC(LogKeys.SESSION_ID, sessionId)} accessed at " +
+ log"timestamp ${MDC(LogKeys.LAST_ACCESS_TIME, lastAccessTimeMs)}.")
}
private[connect] def setCustomInactiveTimeoutMs(newInactiveTimeoutMs:
Option[Long]): Unit = {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
