This is an automated email from the ASF dual-hosted git repository.

sarutak pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 1005e00177f7 [MINOR][CORE] Remove invalid `NioBlockTransferService` 
comment
1005e00177f7 is described below

commit 1005e00177f717445d9c62185d06015583217cc6
Author: Dongjoon Hyun <[email protected]>
AuthorDate: Fri Oct 24 05:07:49 2025 +0900

    [MINOR][CORE] Remove invalid `NioBlockTransferService` comment
    
    ### What changes were proposed in this pull request?
    
    This PR aims to remove invalid comment about `NioBlockTransferService`.
    
    ### Why are the changes needed?
    
    `NioBlockTransferService` was deprecated at Apache Spark 1.5.0 and removed 
at 1.6.0.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No, this is a removal of comment.
    
    ### How was this patch tested?
    
    Manual review.
    
    **BEFORE**
    
    ```
    $ git grep -i NioBlockTransferService | wc -l
           1
    ```
    
    **AFTER**
    
    ```
    $ git grep -i NioBlockTransferService | wc -l
           0
    ```
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    No.
    
    Closes #52710 from dongjoon-hyun/NioBlockTransferService.
    
    Authored-by: Dongjoon Hyun <[email protected]>
    Signed-off-by: Kousuke Saruta <[email protected]>
---
 core/src/main/scala/org/apache/spark/storage/BlockManager.scala | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/src/main/scala/org/apache/spark/storage/BlockManager.scala 
b/core/src/main/scala/org/apache/spark/storage/BlockManager.scala
index 602e8d068fb6..797b00eabc8a 100644
--- a/core/src/main/scala/org/apache/spark/storage/BlockManager.scala
+++ b/core/src/main/scala/org/apache/spark/storage/BlockManager.scala
@@ -2184,7 +2184,7 @@ private[spark] class BlockManager(
     decommissioner.foreach(_.stop())
     blockTransferService.close()
     if (blockStoreClient ne blockTransferService) {
-      // Closing should be idempotent, but maybe not for the 
NioBlockTransferService.
+      // Closing should be idempotent
       blockStoreClient.close()
     }
     remoteBlockTempFileManager.stop()


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to