This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 16fd02321cd2 [SPARK-54238][CORE][TESTS] Clean up unused `private val
regenerateCommand` from `SparkThrowableSuite`
16fd02321cd2 is described below
commit 16fd02321cd25f5b803d4e5ba33ba8886b4627bf
Author: yangjie01 <[email protected]>
AuthorDate: Fri Nov 7 08:31:36 2025 -0800
[SPARK-54238][CORE][TESTS] Clean up unused `private val regenerateCommand`
from `SparkThrowableSuite`
### What changes were proposed in this pull request?
This PR moves the comment about regenerating the error class file to the
class comment of SparkThrowableSuite and cleans up the unused private val
regenerateCommand from SparkThrowableSuite.
### Why are the changes needed?
Code cleanup
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass Github Actions
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #52938 from LuciferYang/SparkThrowableSuite-comments.
Authored-by: yangjie01 <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
---
.../test/scala/org/apache/spark/SparkThrowableSuite.scala | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/core/src/test/scala/org/apache/spark/SparkThrowableSuite.scala
b/core/src/test/scala/org/apache/spark/SparkThrowableSuite.scala
index acaef2512648..09e810fbf9ed 100644
--- a/core/src/test/scala/org/apache/spark/SparkThrowableSuite.scala
+++ b/core/src/test/scala/org/apache/spark/SparkThrowableSuite.scala
@@ -37,18 +37,14 @@ import org.apache.spark.util.Utils
/**
* Test suite for Spark Throwables.
+ * To re-generate the error class file, run:
+ * {{{
+ * SPARK_GENERATE_GOLDEN_FILES=1 build/sbt \
+ * "core/testOnly *SparkThrowableSuite -- -t \"Error conditions are
correctly formatted\""
+ * }}}
*/
class SparkThrowableSuite extends SparkFunSuite {
- /* Used to regenerate the error class file. Run:
- {{{
- SPARK_GENERATE_GOLDEN_FILES=1 build/sbt \
- "core/testOnly *SparkThrowableSuite -- -t \"Error conditions are
correctly formatted\""
- }}}
- */
- private val regenerateCommand = "SPARK_GENERATE_GOLDEN_FILES=1 build/sbt " +
- "\"core/testOnly *SparkThrowableSuite -- -t \\\"Error conditions are
correctly formatted\\\"\""
-
private val errorJsonFilePath = getWorkspaceFilePath(
"common", "utils", "src", "main", "resources", "error",
"error-conditions.json")
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
