This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-3.5
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-3.5 by this push:
new e57945ca72c8 [SPARK-54242][BUILD] Skip `Checkstyle` if
`NOLINT_ON_COMPILE` is true
e57945ca72c8 is described below
commit e57945ca72c8b351ae9662dbb64b1e300b5a4512
Author: Dongjoon Hyun <[email protected]>
AuthorDate: Fri Nov 7 09:59:32 2025 -0800
[SPARK-54242][BUILD] Skip `Checkstyle` if `NOLINT_ON_COMPILE` is true
This PR aims to skip `Checkstyle` if `NOLINT_ON_COMPILE` is true.
Like `Scalastyle`, `Checkstyle` is also a kind of linting. So, we had
better skip it when a user set `NOLINT_ON_COMPILE` to `true`.
No Spark behavior change because this is only a build change.
Pass the CIs and manually.
```
$ NOLINT_ON_COMPILE=true build/sbt package | grep checkstyle
```
No.
Closes #52943 from dongjoon-hyun/SPARK-54242.
Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 7f81bd7436feb31ed6e4c61bc71ad8580fa5ad66)
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit a00a872214bb9648fb72ee409359884170b1bade)
Signed-off-by: Dongjoon Hyun <[email protected]>
---
project/SparkBuild.scala | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/project/SparkBuild.scala b/project/SparkBuild.scala
index c5254658db5e..daa3ebac992f 100644
--- a/project/SparkBuild.scala
+++ b/project/SparkBuild.scala
@@ -410,7 +410,8 @@ object SparkBuild extends PomBuild {
/* Enable shared settings on all projects */
(allProjects ++ optionallyEnabledProjects ++ assemblyProjects ++
copyJarsProjects ++ Seq(spark, tools))
.foreach(enable(sharedSettings ++ DependencyOverrides.settings ++
- ExcludedDependencies.settings ++ Checkstyle.settings))
+ ExcludedDependencies.settings ++
+ (if (sys.env.contains("NOLINT_ON_COMPILE")) Nil else
Checkstyle.settings)))
/* Enable tests settings for all projects except examples, assembly and
tools */
(allProjects ++
optionallyEnabledProjects).foreach(enable(TestSettings.settings))
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
