This is an automated email from the ASF dual-hosted git repository.
sarutak pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 3ac9d9e32bd2 [SPARK-54830][SQL][BUILD][FOLLOWUP] Add comments to
remind that the SQL module should use the same `-Xmx` setting in both Maven and
SBT tests
3ac9d9e32bd2 is described below
commit 3ac9d9e32bd217b3ec249367eb7aa97d53ce15b1
Author: yangjie01 <[email protected]>
AuthorDate: Mon Jan 19 18:35:54 2026 +0900
[SPARK-54830][SQL][BUILD][FOLLOWUP] Add comments to remind that the SQL
module should use the same `-Xmx` setting in both Maven and SBT tests
### What changes were proposed in this pull request?
This pr incorporates suggestions from
https://github.com/apache/spark/pull/53847#discussion_r2703643610 by adding
comments to remind that the SQL module should utilize the same `-Xmx` setting
in both Maven and SBT tests.
### Why are the changes needed?
Add necessary comments.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass Github Actions
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #53851 from LuciferYang/SPARK-54830-FOLLOWUP2.
Authored-by: yangjie01 <[email protected]>
Signed-off-by: Kousuke Saruta <[email protected]>
---
project/SparkBuild.scala | 1 +
sql/core/pom.xml | 1 +
2 files changed, 2 insertions(+)
diff --git a/project/SparkBuild.scala b/project/SparkBuild.scala
index 83b5ee84478a..1cbb58fd5b29 100644
--- a/project/SparkBuild.scala
+++ b/project/SparkBuild.scala
@@ -1324,6 +1324,7 @@ object SQL {
lazy val settings = Seq(
// SPARK-54830: avoid AdaptiveQueryExecSuite OOM, since computing order
independent shuffle checksum needs more
// memory for test case introduced by SPARK-48037 which set shuffle
partition to 16777216
+ // It needs to be consistent with the configuration of the
`scalatest-maven-plugin` in `sql/core/pom.xml`.
(Test / javaOptions) += "-Xmx6g",
// Setting version for the protobuf compiler. This has to be propagated to
every sub-project
// even if the project is not using it.
diff --git a/sql/core/pom.xml b/sql/core/pom.xml
index c5201065c604..7f321677ff2f 100644
--- a/sql/core/pom.xml
+++ b/sql/core/pom.xml
@@ -344,6 +344,7 @@
<groupId>org.scalatest</groupId>
<artifactId>scalatest-maven-plugin</artifactId>
<configuration>
+ <!-- SPARK-54830: Increase `-Xmx` to 6g to prevent OOM during
testing, ensuring consistency with the SQL module configuration in
`SparkBuild.scala`.-->
<argLine>-ea -Xmx6g -Xss4m
-XX:ReservedCodeCacheSize=${CodeCacheSize} ${extraJavaTestArgs}
-Dio.netty.tryReflectionSetAccessible=true</argLine>
</configuration>
</plugin>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
