This is an automated email from the ASF dual-hosted git repository.

dongjoon-hyun pushed a commit to branch branch-4.x
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-4.x by this push:
     new 5b3c27423311 [SPARK-57719][SQL][TEST] Move 
`IdentifierClauseParserSuite` to the catalyst parser package
5b3c27423311 is described below

commit 5b3c27423311b21004343539f59e4ac782a188ef
Author: Dongjoon Hyun <[email protected]>
AuthorDate: Fri Jun 26 08:49:30 2026 -0700

    [SPARK-57719][SQL][TEST] Move `IdentifierClauseParserSuite` to the catalyst 
parser package
    
    ### What changes were proposed in this pull request?
    
    This PR moves `IdentifierClauseParserSuite` to 
`org.apache.spark.sql.catalyst.parser` (`sql/catalyst`) so its directory and 
package match.
    
    ### Why are the changes needed?
    
    This file was introduced at Spark 4.1.1 by the following.
    - https://github.com/apache/spark/pull/53407
    
    
https://github.com/apache/spark/blob/688064e691a63a44075dee769eb07ceed19068f6/sql/core/src/test/scala/org/apache/spark/sql/execution/command/IdentifierClauseParserSuite.scala#L18-L18
    
    The suite is a Catalyst-level parser test (extends `AnalysisTest`, uses 
`CatalystSqlParser`) with no `sql/core` dependency, but it was placed under 
`execution/command` while declaring the top-level `org.apache.spark.sql` 
package. It's weird. Moving it next to the sibling parser suites fixes the 
directory/package mismatch.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    Pass the CIs.
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    Generated-by: Claude Opus 4.8
    
    Closes #56813 from dongjoon-hyun/SPARK-57719.
    
    Authored-by: Dongjoon Hyun <[email protected]>
    Signed-off-by: Dongjoon Hyun <[email protected]>
    (cherry picked from commit 1409070215a4f5b60c42a027b132ac6ce8f8c805)
    Signed-off-by: Dongjoon Hyun <[email protected]>
---
 .../spark/sql/catalyst/parser}/IdentifierClauseParserSuite.scala       | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git 
a/sql/core/src/test/scala/org/apache/spark/sql/execution/command/IdentifierClauseParserSuite.scala
 
b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/IdentifierClauseParserSuite.scala
similarity index 99%
rename from 
sql/core/src/test/scala/org/apache/spark/sql/execution/command/IdentifierClauseParserSuite.scala
rename to 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/IdentifierClauseParserSuite.scala
index c2efc43ae576..d62cdf1f3c15 100644
--- 
a/sql/core/src/test/scala/org/apache/spark/sql/execution/command/IdentifierClauseParserSuite.scala
+++ 
b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/IdentifierClauseParserSuite.scala
@@ -15,12 +15,11 @@
  * limitations under the License.
  */
 
-package org.apache.spark.sql
+package org.apache.spark.sql.catalyst.parser
 
 import org.apache.spark.sql.catalyst.analysis.{AnalysisTest, 
ExpressionWithUnresolvedIdentifier, UnresolvedAttribute, 
UnresolvedExtractValue, UnresolvedFunction, UnresolvedInlineTable, 
UnresolvedStar}
 import org.apache.spark.sql.catalyst.expressions.{Alias, Cast, LambdaFunction, 
Literal, UnresolvedNamedLambdaVariable}
 import org.apache.spark.sql.catalyst.parser.CatalystSqlParser.parsePlan
-import org.apache.spark.sql.catalyst.parser.ParseException
 import org.apache.spark.sql.catalyst.plans.logical.{InsertIntoStatement, 
OneRowRelation, Pivot, Project, SubqueryAlias, Unpivot}
 import org.apache.spark.sql.catalyst.util.EvaluateUnresolvedInlineTable
 import org.apache.spark.sql.types.{IntegerType, StringType, StructField, 
StructType}


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to