This is an automated email from the ASF dual-hosted git repository.

dongjoon-hyun pushed a commit to branch branch-4.0
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-4.0 by this push:
     new 1d7e61ad150b [SPARK-58158][4.0][CORE][UI][FOLLOWUP] Fix broken jQuery 
import path in executorspage.test.js
1d7e61ad150b is described below

commit 1d7e61ad150b35bcaaab6f7223428189ccc1da9d
Author: YangJie <[email protected]>
AuthorDate: Tue Jul 21 08:57:08 2026 -0700

    [SPARK-58158][4.0][CORE][UI][FOLLOWUP] Fix broken jQuery import path in 
executorspage.test.js
    
    ### What changes were proposed in this pull request?
    
    Fix the jQuery import path in `ui-test/tests/executorspage.test.js` on 
`branch-4.0`, changing `jquery.min.js` to `jquery-3.5.1.min.js`.
    
    ### Why are the changes needed?
    
    The `executorspage.test.js` added by SPARK-58158 imports `jquery.min.js`. 
That file name only exists on `master`, where SPARK-54235 (a master-only jQuery 
3.5.1 -> 3.7.1 upgrade) renamed `jquery-3.5.1.min.js` to the version-agnostic 
`jquery.min.js`. SPARK-54235 was not backported, so on `branch-4.0` the file is 
still `jquery-3.5.1.min.js` and the import fails:
    
    ```
    FAIL tests/executorspage.test.js
      Cannot find module '.../ui/static/jquery.min.js' from 
'tests/executorspage.test.js'
    ```
    
    This breaks the daily "Run Spark UI tests" job on `branch-4.0` (e.g. the UI 
test job in https://github.com/apache/spark/actions/runs/29558510791). The 
other ui-test files on this branch already import `jquery-3.5.1.min.js`; this 
aligns `executorspage.test.js` with them. The `jquery.dataTables.min.js` import 
on the following line is unaffected (that file exists on the branch).
    
    ### Does this PR introduce _any_ user-facing change?
    
    No. Test-only.
    
    ### How was this patch tested?
    
    Ran the ui-test suite locally on `branch-4.0` with the fix:
    
    ```
    cd ui-test
    npm install --save-dev
    node --experimental-vm-modules node_modules/.bin/jest
    
    Test Suites: 4 passed, 4 total
    Tests:       12 passed, 12 total
    ```
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    Generated-by: Claude Code (Opus 4.8)
    
    Closes #57394 from LuciferYang/SPARK-58158-jquery-40.
    
    Authored-by: YangJie <[email protected]>
    Signed-off-by: Dongjoon Hyun <[email protected]>
---
 ui-test/tests/executorspage.test.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui-test/tests/executorspage.test.js 
b/ui-test/tests/executorspage.test.js
index 409818469054..59716b4dc5cc 100644
--- a/ui-test/tests/executorspage.test.js
+++ b/ui-test/tests/executorspage.test.js
@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import 
'../../core/src/main/resources/org/apache/spark/ui/static/jquery.min.js';
+import 
'../../core/src/main/resources/org/apache/spark/ui/static/jquery-3.5.1.min.js';
 import 
'../../core/src/main/resources/org/apache/spark/ui/static/jquery.dataTables.min.js';
 import { formatLossReason } from 
'../../core/src/main/resources/org/apache/spark/ui/static/executorspage.js';
 


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to