This is an automated email from the ASF dual-hosted git repository.
cloud-fan pushed a commit to branch branch-4.x
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-4.x by this push:
new 5bdfc2f32604 [SPARK-58107][CORE][FOLLOWUP] Fix stale identifier in
local-checkpoint self-check comment
5bdfc2f32604 is described below
commit 5bdfc2f32604694fa54f54ecb4f6350bb135b971
Author: Juliusz Sompolski <[email protected]>
AuthorDate: Thu Jul 23 22:28:44 2026 +0800
[SPARK-58107][CORE][FOLLOWUP] Fix stale identifier in local-checkpoint
self-check comment
### What changes were proposed in this pull request?
Follow-up to
[SPARK-58107](https://issues.apache.org/jira/browse/SPARK-58107). In
`BlockManager.getLocalValues`, the read-side self-check comment referred to
`verifySealed`; the
`BlockInfo` field it checks is `verifySealedChecksum`. Corrected the
comment.
Comment-only change.
### Why are the changes needed?
The comment names a field that does not exist (`verifySealed`), which is
misleading when reading the
self-check logic. The actual field is `verifySealedChecksum`.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No tests needed - source comment only, no behavioral effect.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)
Closes #57465 from
juliuszsompolski/julek_data/checksum-verifysealed-comment.
Authored-by: Juliusz Sompolski <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
(cherry picked from commit 05ceafd9db720bdd36cf90ad1e24e496bb232564)
Signed-off-by: Wenchen Fan <[email protected]>
---
core/src/main/scala/org/apache/spark/storage/BlockManager.scala | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/core/src/main/scala/org/apache/spark/storage/BlockManager.scala
b/core/src/main/scala/org/apache/spark/storage/BlockManager.scala
index 38c391efad97..801f4c0b7472 100644
--- a/core/src/main/scala/org/apache/spark/storage/BlockManager.scala
+++ b/core/src/main/scala/org/apache/spark/storage/BlockManager.scala
@@ -1158,8 +1158,9 @@ private[spark] class BlockManager(
// For a sealed block whose local copy does not match the sealed
checksum, skip the local
// copy and fall through to a remote (authoritative) location: it is a
stale replica the
// seal is evicting, but that eviction is async and may not have
landed. This self-check
- // makes correctness independent of the eviction landing. Only
`verifySealed` blocks are
- // checked; an unsealed block, or one checksummed only for
observation, is served as-is.
+ // makes correctness independent of the eviction landing. Only
`verifySealedChecksum`
+ // blocks are checked; an unsealed block, or one checksummed only for
observation, is
+ // served as-is.
// This is only used with localCheckpoint, whose lineage is cut once
sealed, so a lost block
// is never recomputed: there is no later, differently-checksummed
re-materialization to
// reconcile here - a skipped local copy means the block is genuinely
gone, not superseded.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
