This is an automated email from the ASF dual-hosted git repository.
dongjoon-hyun pushed a commit to branch branch-4.x
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-4.x by this push:
new d70409ffd815 [SPARK-58328][K8S] Remove stale TODO comments from
`DriverKubernetesCredentialsFeatureStep`
d70409ffd815 is described below
commit d70409ffd8151c52ba7edcfc9b56aa8aee0279d0
Author: Dongjoon Hyun <[email protected]>
AuthorDate: Fri Jul 24 12:39:30 2026 -0700
[SPARK-58328][K8S] Remove stale TODO comments from
`DriverKubernetesCredentialsFeatureStep`
### What changes were proposed in this pull request?
Remove two stale TODO comments from
`DriverKubernetesCredentialsFeatureStep`:
1. The TODO suggesting a struct for the credential fields: a struct-based
refactoring was
prototyped and did not pay off because the four credentials have
different data sources,
so the repetition would just move into the construction site.
2. The TODO about applying this step in the caller:
`KubernetesDriverBuilder` applies all
feature steps through a uniform fold with per-step exclusion support, so
the current
design stands.
### Why are the changes needed?
Both TODOs have been there since 2018 and no longer reflect actionable work.
### Does this PR introduce _any_ user-facing change?
No. Comment-only change.
### How was this patch tested?
Pass the CIs.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Fable 5
Closes #57506 from dongjoon-hyun/SPARK-58328.
Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 1e720dabbd58738bc733bc18372e79bb78657837)
Signed-off-by: Dongjoon Hyun <[email protected]>
---
.../deploy/k8s/features/DriverKubernetesCredentialsFeatureStep.scala | 3 ---
1 file changed, 3 deletions(-)
diff --git
a/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverKubernetesCredentialsFeatureStep.scala
b/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverKubernetesCredentialsFeatureStep.scala
index 83f8ed01774d..39dfec95176c 100644
---
a/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverKubernetesCredentialsFeatureStep.scala
+++
b/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverKubernetesCredentialsFeatureStep.scala
@@ -32,8 +32,6 @@ import
org.apache.spark.deploy.k8s.KubernetesUtils.buildPodWithServiceAccount
private[spark] class DriverKubernetesCredentialsFeatureStep(kubernetesConf:
KubernetesConf)
extends KubernetesFeatureConfigStep {
- // TODO clean up this class, and credentials in general. See also
SparkKubernetesClientFactory.
- // We should use a struct to hold all creds-related fields. A lot of the
code is very repetitive.
private val maybeMountedOAuthTokenFile = kubernetesConf.getOption(
s"$KUBERNETES_AUTH_DRIVER_MOUNTED_CONF_PREFIX.$OAUTH_TOKEN_FILE_CONF_SUFFIX")
@@ -61,7 +59,6 @@ private[spark] class
DriverKubernetesCredentialsFeatureStep(kubernetesConf: Kube
s"$KUBERNETES_AUTH_DRIVER_CONF_PREFIX.$CLIENT_CERT_FILE_CONF_SUFFIX",
"Driver client cert file")
- // TODO decide whether or not to apply this step entirely in the caller,
i.e. the builder.
private val shouldMountSecret = oauthTokenBase64.isDefined ||
caCertDataBase64.isDefined ||
clientKeyDataBase64.isDefined ||
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
