This is an automated email from the ASF dual-hosted git repository.
uros-b pushed a commit to branch branch-4.x
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-4.x by this push:
new ee7b61c54c56 [SPARK-58355][SS] Fix grammar in metadata log null-check
message
ee7b61c54c56 is described below
commit ee7b61c54c5698d952de1d98f6fcf2d3558830b3
Author: Uros Bojanic <[email protected]>
AuthorDate: Mon Jul 27 11:32:57 2026 +0000
[SPARK-58355][SS] Fix grammar in metadata log null-check message
### What changes were proposed in this pull request?
Fixes the grammar of the null-metadata `require(...)` message in
`HDFSMetadataLog` and `AsyncOffsetSeqLog`: "'null' metadata cannot written to a
metadata log" becomes "... cannot be written ...".
### Why are the changes needed?
The message was missing the word "be". The sibling `AsyncCommitLog` already
uses the correct phrasing, so this brings the two outliers in line. The message
is a plain `require()` string, not part of the error-condition framework, so it
is not golden-tested.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Message-text-only change; no behavior change. No tests needed.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)
Closes #57546 from uros-b/error-metadatalog-cannot-be-written.
Lead-authored-by: Uros Bojanic <[email protected]>
Co-authored-by: Uros Bojanic <[email protected]>
Signed-off-by: Uros Bojanic <[email protected]>
(cherry picked from commit a663376d954fc950cc949d5f0a9d385cb262edfb)
Signed-off-by: Uros Bojanic <[email protected]>
---
.../spark/sql/execution/streaming/checkpointing/AsyncOffsetSeqLog.scala | 2 +-
.../spark/sql/execution/streaming/checkpointing/HDFSMetadataLog.scala | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
a/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/checkpointing/AsyncOffsetSeqLog.scala
b/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/checkpointing/AsyncOffsetSeqLog.scala
index 14fb4620527c..c2ae9ac0fae6 100644
---
a/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/checkpointing/AsyncOffsetSeqLog.scala
+++
b/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/checkpointing/AsyncOffsetSeqLog.scala
@@ -83,7 +83,7 @@ class AsyncOffsetSeqLog(
* to indicate some write error.
*/
def addAsync(batchId: Long, metadata: OffsetSeqBase):
CompletableFuture[(Long, Boolean)] = {
- require(metadata != null, "'null' metadata cannot written to a metadata
log")
+ require(metadata != null, "'null' metadata cannot be written to a metadata
log")
def issueAsyncWrite(batchId: Long): CompletableFuture[Long] = {
lastCommitIssuedTimestampMs.set(clock.getTimeMillis())
diff --git
a/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/checkpointing/HDFSMetadataLog.scala
b/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/checkpointing/HDFSMetadataLog.scala
index b06a90de44c4..3f2271ac2b2c 100644
---
a/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/checkpointing/HDFSMetadataLog.scala
+++
b/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/checkpointing/HDFSMetadataLog.scala
@@ -133,7 +133,7 @@ class HDFSMetadataLog[T <: AnyRef : ClassTag](
* metadata has already been stored, this method will return `false`.
*/
override def add(batchId: Long, metadata: T): Boolean = {
- require(metadata != null, "'null' metadata cannot written to a metadata
log")
+ require(metadata != null, "'null' metadata cannot be written to a metadata
log")
val res = addNewBatchByStream(batchId) { output => serialize(metadata,
output) }
if (metadataCacheEnabled && res) batchCache.put(batchId, metadata)
res
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]