This is an automated email from the ASF dual-hosted git repository.
uros-b pushed a commit to branch branch-4.3
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-4.3 by this push:
new 78b925cb7ccd [SPARK-58663][BUILD] Fix typos and grammar in root
pom.xml comments
78b925cb7ccd is described below
commit 78b925cb7ccdc0600c2601f2fff266c7d1b06c71
Author: Uros Bojanic <[email protected]>
AuthorDate: Mon Aug 10 04:30:03 2026 +0000
[SPARK-58663][BUILD] Fix typos and grammar in root pom.xml comments
### What changes were proposed in this pull request?
Fixes grammar and typos in comments within the root `pom.xml`:
- `produce the same results` to `produces the same results` (singular
subject)
- `needed when run MapReduce test in Hive 2.3` to `needed when running
MapReduce tests in Hive 2.3`
- `for support Datasketches HllSketch` to `to support Datasketches
HllSketch`
- `Couple of dependencies` to `A couple of dependencies`
- `If one don't use OSGi` to `If one doesn't use OSGi`
- `needs an external plugin handle it` to `needs an external plugin to
handle it`
- `in production of for distribution` to `in production or for distribution`
It also spells `macOS` consistently in the two comments that used `MacOS`;
the file already uses `macOS` elsewhere, including the profile id.
### Why are the changes needed?
These are plain grammatical errors in comments that explain non-obvious
build decisions, so they are worth keeping readable. The `macOS` casing is
corrected because one of the affected lines is already being touched.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Every edit is inside an XML comment body: no versions, coordinates, scopes,
or ordering are changed, and the `SPARK-38885` and `SPARK-16484` references in
those comments are preserved. The POM was confirmed to still parse as
well-formed XML, and no dev script or CI workflow matches on this comment text,
so the build is unaffected.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)
Closes #57870 from uros-b/pom-comment-typos.
Authored-by: Uros Bojanic <[email protected]>
Signed-off-by: Uros Bojanic <[email protected]>
(cherry picked from commit 2d14781f1a61bac9ecac50ff2df74a6d85136e22)
Signed-off-by: Uros Bojanic <[email protected]>
---
pom.xml | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/pom.xml b/pom.xml
index 6b79186d7eae..a40658107ffb 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1025,7 +1025,7 @@
</exclusions>
</dependency>
<!-- SPARK-38885: After Netty 4.1.76, add the following `Netty`
dependencies explicitly
- to ensure `./dev/test-dependencies.sh` produce the same results on
Linux and MacOS.
+ to ensure `./dev/test-dependencies.sh` produces the same results on
Linux and macOS.
-->
<dependency>
<groupId>io.netty</groupId>
@@ -2306,7 +2306,7 @@
</exclusion>
</exclusions>
</dependency>
- <!-- hive-llap-client is needed when run MapReduce test in Hive 2.3. -->
+ <!-- hive-llap-client is needed when running MapReduce tests in Hive
2.3. -->
<dependency>
<groupId>${hive.group}</groupId>
<artifactId>hive-llap-client</artifactId>
@@ -2647,7 +2647,7 @@
<artifactId>arpack</artifactId>
<version>${netlib.ludovic.dev.version}</version>
</dependency>
- <!-- SPARK-16484 add `datasketches-java` for support Datasketches
HllSketch -->
+ <!-- SPARK-16484 add `datasketches-java` to support Datasketches
HllSketch -->
<dependency>
<groupId>org.apache.datasketches</groupId>
<artifactId>datasketches-java</artifactId>
@@ -3370,10 +3370,10 @@
</executions>
</plugin>
<!--
- Couple of dependencies are coming in bundle format (bundle is just a
normal jar which
- contains OSGi metadata in the manifest). If one don't use OSGi, then a
bundle will work as
+ A couple of dependencies are coming in bundle format (bundle is just a
normal jar which
+ contains OSGi metadata in the manifest). If one doesn't use OSGi, then
a bundle will work as
any other jar. Since maven doesn't have native bundle support it needs
an external plugin
- handle it. If the plugin is not added then the build can't resolve
bundle dependencies.
+ to handle it. If the plugin is not added then the build can't resolve
bundle dependencies.
-->
<plugin>
<groupId>org.apache.felix</groupId>
@@ -3582,7 +3582,7 @@
<!--
This is a profile to enable the use of the ASF snapshot and staging
repositories
during a build. It is useful when testing against nightly or RC releases
of dependencies.
- It MUST NOT be used when building copies of Spark to use in production of
for distribution,
+ It MUST NOT be used when building copies of Spark to use in production or
for distribution,
-->
<profile>
<id>snapshots-and-staging</id>
@@ -3657,7 +3657,7 @@
<profile>
<id>jjwt-provided</id>
</profile>
- <!-- use org.openlabtesting.leveldbjni on aarch64 platform except MacOS -->
+ <!-- use org.openlabtesting.leveldbjni on aarch64 platform except macOS -->
<profile>
<id>aarch64</id>
<properties>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
