This is an automated email from the ASF dual-hosted git repository.
uros-b pushed a commit to branch branch-4.x
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-4.x by this push:
new 658a23cbf4e7 [SPARK-58690][CORE] Fix typos in storage package comments
658a23cbf4e7 is described below
commit 658a23cbf4e75a64e005dc2b60257f25fa38d9ba
Author: Uros <[email protected]>
AuthorDate: Tue Aug 18 14:37:53 2026 +0000
[SPARK-58690][CORE] Fix typos in storage package comments
### What changes were proposed in this pull request?
Fixes four comment typos under
`core/src/main/scala/org/apache/spark/storage/`:
- `BlockInfoManager`: `Helper for lock acquisistion` to `acquisition`
- `BlockManagerMasterEndpoint`: `broadcasts the serialized mapstatues` to
`map statuses`
- `ShuffleBlockFetcherIterator`: `The exception could only be throwed by`
to `thrown`
- `ShuffleBlockFetcherIterator`: `push-merged shuffle files are storedl` to
`stored`
### Why are the changes needed?
Each is a plain misspelling, and each is the only occurrence of that
spelling in the repository. On the second one, the surrounding comment
consistently wraps code identifiers in backticks (``
`MapOutputTracker.serializeOutputStatuses` ``, `` `updateMapOutput` ``), so the
intent is the English plural rather than the `mapStatuses` field, and it is
rendered as two words accordingly.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Comment text only, with no effect on compiled code. Each edited line was
confirmed to sit inside a scaladoc or `//` comment, and no identifier, string
literal, or error message is touched. The longest resulting line is 97
characters, within the limit.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)
Closes #57891 from uros-b/typo-storage-comments.
Authored-by: Uros <[email protected]>
Signed-off-by: Uros Bojanic <[email protected]>
(cherry picked from commit 6c24c560392c7f7fda56e75cc5e003b5af4fd358)
Signed-off-by: Uros Bojanic <[email protected]>
---
core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala | 2 +-
.../scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala | 2 +-
.../scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git
a/core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala
b/core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala
index 4dc8d1f1b50c..2c0f82283e1b 100644
--- a/core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala
+++ b/core/src/main/scala/org/apache/spark/storage/BlockInfoManager.scala
@@ -288,7 +288,7 @@ private[storage] class
BlockInfoManager(trackingCacheVisibility: Boolean = false
}
/**
- * Helper for lock acquisistion.
+ * Helper for lock acquisition.
*/
private def acquireLock(
blockId: BlockId,
diff --git
a/core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
b/core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
index 08d802740618..beca0d11d1c5 100644
---
a/core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
+++
b/core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
@@ -804,7 +804,7 @@ class BlockManagerMasterEndpoint(
case ShuffleIndexBlockId(shuffleId, mapId, _) =>
// SPARK-36782: Invoke `MapOutputTracker.updateMapOutput` within the
thread
// `dispatcher-BlockManagerMaster` could lead to the deadlock when
- // `MapOutputTracker.serializeOutputStatuses` broadcasts the serialized
mapstatues under
+ // `MapOutputTracker.serializeOutputStatuses` broadcasts the serialized
map statuses under
// the acquired write lock. The broadcast block would report its status
to
// `BlockManagerMasterEndpoint`, while the `BlockManagerMasterEndpoint`
is occupied by
// `updateMapOutput` since it's waiting for the write lock. Thus, we
use `Future` to call
diff --git
a/core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
b/core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
index cb15e954bb38..84707424d7b0 100644
---
a/core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
+++
b/core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
@@ -885,7 +885,7 @@ final class ShuffleBlockFetcherIterator(
bufIn
}
} catch {
- // The exception could only be throwed by local shuffle block
+ // The exception could only be thrown by local shuffle block
case e: IOException =>
assert(buf.isInstanceOf[FileSegmentManagedBuffer])
e match {
@@ -1668,7 +1668,7 @@ object ShuffleBlockFetcherIterator {
* of shuffle by an indeterminate stage attempt.
* @param reduceId reduce id.
* @param bitmaps bitmaps for every chunk.
- * @param localDirs local directories where the push-merged shuffle files
are storedl
+ * @param localDirs local directories where the push-merged shuffle files
are stored
*/
private[storage] case class PushMergedLocalMetaFetchResult(
shuffleId: Int,
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
