This is an automated email from the ASF dual-hosted git repository.

cloud-fan pushed a commit to branch branch-4.x
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-4.x by this push:
     new 3754626a3229 [SPARK-58021][CONNECT][FOLLOWUP] Strip launcher-owned 
binding address from seed configuration
3754626a3229 is described below

commit 3754626a322966e833cae8633acaca18709e2358
Author: Wenchen Fan <[email protected]>
AuthorDate: Mon Aug 24 14:42:48 2026 +0800

    [SPARK-58021][CONNECT][FOLLOWUP] Strip launcher-owned binding address from 
seed configuration
    
    ### What changes were proposed in this pull request?
    
    Followup to https://github.com/apache/spark/pull/57684.
    
    Add `spark.connect.grpc.binding.address` to the settings removed by
    `_strip_launcher_conf` before writing local Connect server seed properties.
    
    ### Why are the changes needed?
    
    The local server launcher sets the binding address explicitly on its 
command line. Removing the
    same setting from seed properties keeps all launcher-owned settings 
centralized and avoids carrying
    a competing value in the generated properties file.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    No new test was added because this completes the existing launcher-owned 
configuration allowlist;
    the behavior is covered by the existing seed-configuration tests from the 
original change.
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    Generated-by: OpenAI Codex (GPT-5)
    
    Closes #58088 from cloud-fan/SPARK-58021-followup-245101.
    
    Authored-by: Wenchen Fan <[email protected]>
    Signed-off-by: Wenchen Fan <[email protected]>
    (cherry picked from commit 7b2c5329d22ca2df799f2910edaf23b0a97f3593)
    Signed-off-by: Wenchen Fan <[email protected]>
---
 python/pyspark/sql/connect/local_server.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/python/pyspark/sql/connect/local_server.py 
b/python/pyspark/sql/connect/local_server.py
index f8c0129f3775..42aabe4d5d8e 100644
--- a/python/pyspark/sql/connect/local_server.py
+++ b/python/pyspark/sql/connect/local_server.py
@@ -333,6 +333,7 @@ def _strip_launcher_conf(conf: Dict[str, Any]) -> Dict[str, 
Any]:
             "spark.api.mode",
             "spark.master",
             "spark.connect.authenticate.token",
+            "spark.connect.grpc.binding.address",
             "spark.connect.grpc.binding.port",
         ) or k.startswith("spark.local.connect."):
             stripped.pop(k)


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to