This is an automated email from the ASF dual-hosted git repository.
HyukjinKwon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark-connect-rust.git
The following commit(s) were added to refs/heads/master by this push:
new 98cbed6 [SPARK-59078][INFRA] Fix master build broken by a
SPARK-59075/59076 semantic conflict
98cbed6 is described below
commit 98cbed609e1916924af5e57c49094b58573074b7
Author: Hyukjin Kwon <[email protected]>
AuthorDate: Fri Aug 28 17:12:01 2026 +0900
[SPARK-59078][INFRA] Fix master build broken by a SPARK-59075/59076
semantic conflict
### What changes were proposed in this pull request?
`cargo test -p apache-spark-connect` currently fails to **compile** on
`master`, breaking `Rust build and test`, `Rust checks`, `WASM UDF feature`,
and the `Coverage` job:
```
error[E0599]: no method named `set_metrics` found for struct
`observation::Observation`
error[E0599]: no method named `set_dataframe` found for struct
`observation::Observation`
```
This is a semantic merge conflict between two PRs that were each green in
isolation:
- **SPARK-59075** added an inline `#[cfg(test)]` test in `observation.rs`
that calls the `pub(crate)` methods `Observation::set_metrics` /
`set_dataframe` (which existed at its base).
- **SPARK-59076** removed those two methods as unused dead code (they had
no production callers).
Merged together, the test references methods that no longer exist. This
drops the obsolete `set_metrics_and_dataframe` test.
Re-adding the methods would be the wrong fix: they are dead code with no
callers, so they would reintroduce the `dead_code` warning that SPARK-59076's
`deny(warnings)` now rejects.
I confirmed `set_metrics`/`set_dataframe` are the only symbols SPARK-59076
removed (so this is the sole break), and that no other reference to them
remains in the tree.
### Why are the changes needed?
`master` does not compile its test targets; CI is red across multiple jobs.
### Does this PR introduce _any_ user-facing change?
No. Removes a stale unit test only.
### How was this patch tested?
`cargo fmt --all --check` passes. The removed test was the only compile
error reported by the failing job, and `git grep` confirms no remaining
references to the removed methods; CI on this PR verifies the build is green
again.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code
Closes #80 from HyukjinKwon/SPARK-59078.
Authored-by: Hyukjin Kwon <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
---
crates/spark-connect/src/observation.rs | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/crates/spark-connect/src/observation.rs
b/crates/spark-connect/src/observation.rs
index d965eb6..47691f6 100644
--- a/crates/spark-connect/src/observation.rs
+++ b/crates/spark-connect/src/observation.rs
@@ -42,22 +42,4 @@ mod tests {
assert_eq!(obs.name(), "test_obs");
assert!(obs.get().is_empty());
}
-
- #[test]
- fn set_metrics_and_dataframe() {
- let mut obs = Observation::new("o");
- let mut m = HashMap::new();
- m.insert("k".to_string(), "v".to_string());
- obs.set_metrics(m);
- assert_eq!(obs.get().get("k").map(|s| s.as_str()), Some("v"));
-
- // set_dataframe just stores the handle; a session-less plan is enough
- // (no RPC is made here).
- let spark = crate::session::SparkSession::builder()
- .remote("sc://localhost:15002")
- .get_or_create()
- .expect("session");
- let df = spark.range(3).unwrap();
- obs.set_dataframe(df);
- }
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
