This is an automated email from the ASF dual-hosted git repository.
nchammas pushed a commit to branch branch-4.x
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-4.x by this push:
new 3c0b3a439873 [SPARK-59920][BUILD] Remove unnecessary `git clean` from
pip tests script
3c0b3a439873 is described below
commit 3c0b3a43987311feef1bc6625c67bf3520fe1dc4
Author: Nicholas Chammas <[email protected]>
AuthorDate: Mon Oct 5 21:32:00 2026 +0300
[SPARK-59920][BUILD] Remove unnecessary `git clean` from pip tests script
### What changes were proposed in this pull request?
Remove the `git clean` step from `run-pip-tests`.
### Why are the changes needed?
This cleanup was added in #42159 to help resolve intermittent space
pressure. It had no other purpose.
It's not necessary anymore. We already free some space on the runner via
the `free-disk-space` parameter to the `setup-build-env` composite action. More
importantly, the runners themselves also have [much more free space][1] than in
prior years when this fix was added.
[1]:
https://github.com/actions/runner-images/issues/14492#issuecomment-5191479879
Looking forward, this cleanup will also make it easier to change when or
how the pip tests are triggered (as part of SPARK-59180), since we no longer
have to worry about `git clean` removing build artifacts that other tests may
need to run.
Finally, an environment preparation step like this, should we ever need to
reintroduce it for some reason, doesn't belong inside the test script. It
should happen upstream of it, so as not to mix in logically unrelated steps
with the actual pip tests themselves.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing CI for this PR [successfully ran the pip tests][ci].
[ci]:
https://github.com/nchammas/spark/actions/runs/36834488478/job/110298902984#step:9:130
I also pushed a temporary commit at 0ce4a1b to get the macOS 26 build to
run and confirmed that the runner has [plenty of space available][mac].
[mac]:
https://github.com/nchammas/spark/actions/runs/36988944346/job/110793319313#step:2:29
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #59182 from nchammas/py-packaging-test-cleanup.
Authored-by: Nicholas Chammas <[email protected]>
Signed-off-by: Nicholas Chammas <[email protected]>
(cherry picked from commit b93fb8d4995949e2bc622a13cf68816b3a12d0a7)
Signed-off-by: Nicholas Chammas <[email protected]>
---
dev/run-pip-tests | 8 --------
1 file changed, 8 deletions(-)
diff --git a/dev/run-pip-tests b/dev/run-pip-tests
index 3097b2727ff9..76a519b561e1 100755
--- a/dev/run-pip-tests
+++ b/dev/run-pip-tests
@@ -25,14 +25,6 @@ shopt -s nullglob
FWDIR="$(cd "$(dirname "$0")"/..; pwd)"
cd "$FWDIR"
-# Clean ignored/untracked files that do not need
-# for pip packaging test. Machines in GitHub Action do not have
-# enough space, see also SPARK-44557.
-# We need to keep the coverage and test report from previous tests in coverage
runs.
-if [[ ! -z "${GITHUB_ACTIONS}" ]]; then
- git clean -d -f -x -e assembly -e python/coverage.xml -e target/test-reports/
-fi
-
echo "Constructing virtual env for testing"
VIRTUALENV_BASE=$(mktemp -d)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
