This is an automated email from the ASF dual-hosted git repository.
viirya pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/spark-connect-gateway.git
The following commit(s) were added to refs/heads/main by this push:
new 131c830 [SPARK-59973] Upgrade the OpenTelemetry crates to 0.33 and
tracing-opentelemetry to 0.34
131c830 is described below
commit 131c830324acdcf2979d1d09d2992c78cea1ec1b
Author: Liang-Chi Hsieh <[email protected]>
AuthorDate: Fri Oct 9 00:49:07 2026 -0700
[SPARK-59973] Upgrade the OpenTelemetry crates to 0.33 and
tracing-opentelemetry to 0.34
### What changes were proposed in this pull request?
Move the six `opentelemetry*` crates from 0.32 to 0.33, and
`tracing-opentelemetry` from 0.33 to 0.34:
```
opentelemetry 0.32 -> 0.33
opentelemetry_sdk 0.32 -> 0.33
opentelemetry-otlp 0.32 -> 0.33
opentelemetry-semantic-conventions 0.32 -> 0.33
opentelemetry-stdout 0.32 -> 0.33
opentelemetry-proto 0.32 -> 0.33
tracing-opentelemetry 0.33 -> 0.34
```
`Cargo.toml` and `Cargo.lock` only — no source changes, as the APIs this
repo uses
are unchanged between 0.32 and 0.33.
This supersedes #41, which is closed.
### Why are the changes needed?
Routine dependency maintenance, but the shape is worth explaining since the
title
names two things and the diff moves eight crates.
These crates share types across their public APIs, so raising one on its own
leaves two majors of `opentelemetry` in the dependency graph and the traits
stop
lining up. `tracing-opentelemetry`'s version is offset by one minor — 0.34
is the
release that tracks `opentelemetry` 0.33 — so the whole family moves
together.
This is the same shape as SPARK-59548, which took the group from 0.31 to
0.32.
Worth noting that dependabot raised this *correctly*, as a single grouped
PR under
the grouping added in SPARK-59550, rather than as the seven individually
unmergeable single-crate PRs it would have produced before. The grouping
also
behaved as intended at the edges: `tracing-opentelemetry` was included,
while
`tracing` and `tracing-subscriber` were left out — they carry no version
coupling
to OpenTelemetry, and sweeping them in would have held their updates behind
this
family for no reason.
### Does this PR introduce _any_ user-facing change?
No. Dependency versions only; no change to configuration, metrics, span
names, or
any emitted telemetry.
### How was this patch tested?
**The check that shows the version skew is actually gone** is the lockfile
resolving a single `opentelemetry`. Building is not sufficient proof — a
skewed
graph still compiles until the mismatched trait is named, which is exactly
how
#8 looked before it failed:
```
$ grep -c '^name = "opentelemetry"$' Cargo.lock
1
```
`opentelemetry` and `opentelemetry_sdk` resolve to 0.33.0,
`tracing-opentelemetry`
to 0.34.0, and `cargo metadata --locked` confirms the lock agrees with the
manifest.
**The tracing integration test matters more here than the unit tests**, and
passes:
```
test tracing_emits_spans_and_propagates_traceparent ... ok
```
Feature unification in this dependency group has previously caused
application
spans to be dropped silently — enabling `opentelemetry`'s
`spec_unstable_logs_enabled` through an unrelated path made the linked
`tracing-opentelemetry` discard them — and neither a build nor the unit
tests
would catch that. This test asserts spans are emitted and `traceparent` is
propagated, so it is the one that would notice.
**The nine Redis integration tests** were run against a real Redis as well
and are
unaffected, as expected.
**Full workspace:**
| check | result |
|---|---|
| `cargo test --workspace` | 204 passed, 0 failed, 10 ignored — same as the
baseline on `main` |
| `cargo clippy --workspace --all-targets -- -D warnings` | clean |
| `cargo fmt --all --check` | clean |
I also confirmed this PR leaves the proto work from #40 and #42 untouched
(`dev/sync-protos.sh` reports `identical: 11`), since a sibling dependabot
PR had
quietly reverted it and that is worth checking rather than assuming.
### Was this patch authored or co-authored using generative AI tooling?
Yes, co-authored with Claude Code.
Closes #43 from viirya/dep-04-opentelemetry-0.33.
Authored-by: Liang-Chi Hsieh <[email protected]>
Signed-off-by: Liang-Chi Hsieh <[email protected]>
---
Cargo.lock | 36 ++++++++++++++++++------------------
Cargo.toml | 14 +++++++-------
2 files changed, 25 insertions(+), 25 deletions(-)
diff --git a/Cargo.lock b/Cargo.lock
index c54c027..759444c 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -872,7 +872,7 @@ source =
"registry+https://github.com/rust-lang/crates.io-index";
checksum = "39cab71617ae0d63f51a36d69f866391735b51691dbda63cf6f96d042b63efeb"
dependencies = [
"libc",
- "windows-sys 0.52.0",
+ "windows-sys 0.61.2",
]
[[package]]
@@ -2073,9 +2073,9 @@ checksum =
"7c87def4c32ab89d880effc9e097653c8da5d6ef28e6b539d313baaacfbafcbe"
[[package]]
name = "opentelemetry"
-version = "0.32.0"
+version = "0.33.0"
source = "registry+https://github.com/rust-lang/crates.io-index";
-checksum = "b0142c63252a9e054e68a4c61a5778f7b14f576274d593f8ce883d191a099682"
+checksum = "6cdb0b1b267eb9db3331b434ed9ddab10d50e280a9adf9d13e5233e2002b61b5"
dependencies = [
"futures-core",
"futures-sink",
@@ -2087,9 +2087,9 @@ dependencies = [
[[package]]
name = "opentelemetry-otlp"
-version = "0.32.0"
+version = "0.33.0"
source = "registry+https://github.com/rust-lang/crates.io-index";
-checksum = "9966929966d17620d7c316c643ba62631826e10021409357772d5eea84f62c35"
+checksum = "699a67345e21962a231955b9059a157e428b219fa5df8efe11f08346fb23a344"
dependencies = [
"http",
"opentelemetry",
@@ -2104,9 +2104,9 @@ dependencies = [
[[package]]
name = "opentelemetry-proto"
-version = "0.32.0"
+version = "0.33.0"
source = "registry+https://github.com/rust-lang/crates.io-index";
-checksum = "56d658ba1faf63f7b9c492cfbe6e0ec365440a16132d3270c1065f7b33f1b638"
+checksum = "25da1ac11a0aeccf38d7f77ee0348715adaf8340f65ad46c94a02c6b20e2f65d"
dependencies = [
"opentelemetry",
"opentelemetry_sdk",
@@ -2117,15 +2117,15 @@ dependencies = [
[[package]]
name = "opentelemetry-semantic-conventions"
-version = "0.32.1"
+version = "0.33.0"
source = "registry+https://github.com/rust-lang/crates.io-index";
-checksum = "c913ac17a6c451661ee255f4625d143e51647ae78ebd969b75e41c4442f4fe47"
+checksum = "d288b1e1bc3590052fbb8f0f635ef248dd9022cf1fbaeb6582b7ad6081a17b87"
[[package]]
name = "opentelemetry-stdout"
-version = "0.32.0"
+version = "0.33.0"
source = "registry+https://github.com/rust-lang/crates.io-index";
-checksum = "a1b1c6a247d79091f0062a5f4bd058589525cf987a8d4c169440d9c1be72f0ad"
+checksum = "9f71803f481d3f5ccbe477edb42a78f473613712b2327835911a9ea0ab069824"
dependencies = [
"chrono",
"opentelemetry",
@@ -2134,9 +2134,9 @@ dependencies = [
[[package]]
name = "opentelemetry_sdk"
-version = "0.32.1"
+version = "0.33.0"
source = "registry+https://github.com/rust-lang/crates.io-index";
-checksum = "9b59f80e1ac4d5ff7a2db8fb6c80badb7f0f3f858211fba08dd9aaec750894f9"
+checksum = "cb39533d9d1c912123efd7d41d7e0c29d16917b60ce15b4c8d87cb1af7f67520"
dependencies = [
"futures-channel",
"futures-executor",
@@ -2590,7 +2590,7 @@ dependencies = [
"once_cell",
"socket2",
"tracing",
- "windows-sys 0.52.0",
+ "windows-sys 0.61.2",
]
[[package]]
@@ -2891,7 +2891,7 @@ dependencies = [
"errno",
"libc",
"linux-raw-sys",
- "windows-sys 0.52.0",
+ "windows-sys 0.61.2",
]
[[package]]
@@ -3569,7 +3569,7 @@ dependencies = [
"getrandom 0.4.3",
"once_cell",
"rustix",
- "windows-sys 0.52.0",
+ "windows-sys 0.61.2",
]
[[package]]
@@ -3973,9 +3973,9 @@ dependencies = [
[[package]]
name = "tracing-opentelemetry"
-version = "0.33.0"
+version = "0.34.0"
source = "registry+https://github.com/rust-lang/crates.io-index";
-checksum = "adbc64cba7137545b8044cb1fe9814f7aacf3c6b5f9b45be8bb5db538befdb26"
+checksum = "0a904802a1b902f43638b677ff2a650847e3b4404101b6c586d648e8c1e3e8fe"
dependencies = [
"js-sys",
"opentelemetry",
diff --git a/Cargo.toml b/Cargo.toml
index 5020b33..98a0c57 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -61,13 +61,13 @@ prost-types = "0.14"
# Logging + telemetry
tracing = "0.1"
tracing-subscriber = { version = "0.3", features = ["env-filter", "json"] }
-opentelemetry = "0.32"
-opentelemetry_sdk = { version = "0.32", features = ["rt-tokio"] }
-opentelemetry-otlp = { version = "0.32", default-features = false, features =
["trace", "grpc-tonic", "tls-ring", "tls-webpki-roots"] }
-opentelemetry-semantic-conventions = "0.32"
-opentelemetry-stdout = "0.32"
-opentelemetry-proto = { version = "0.32", default-features = false, features =
["gen-tonic", "trace"] }
-tracing-opentelemetry = "0.33"
+opentelemetry = "0.33"
+opentelemetry_sdk = { version = "0.33", features = ["rt-tokio"] }
+opentelemetry-otlp = { version = "0.33", default-features = false, features =
["trace", "grpc-tonic", "tls-ring", "tls-webpki-roots"] }
+opentelemetry-semantic-conventions = "0.33"
+opentelemetry-stdout = "0.33"
+opentelemetry-proto = { version = "0.33", default-features = false, features =
["gen-tonic", "trace"] }
+tracing-opentelemetry = "0.34"
# Config + utilities
serde = { version = "1", features = ["derive"] }
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
