Merge pull request #68 from mosharaf/master Faster and stable/reliable broadcast
HttpBroadcast is noticeably slow, but the alternatives (TreeBroadcast or BitTorrentBroadcast) are notoriously unreliable. The main problem with them is they try to manage the memory for the pieces of a broadcast themselves. Right now, the BroadcastManager does not know which machines the tasks reading from a broadcast variable is running and when they have finished. Consequently, we try to guess and often guess wrong, which blows up the memory usage and kills/hangs jobs. This very simple implementation solves the problem by not trying to manage the intermediate pieces; instead, it offloads that duty to the BlockManager which is quite good at juggling blocks. Otherwise, it is very similar to the BitTorrentBroadcast implementation (without fancy optimizations). And it runs much faster than HttpBroadcast we have right now. I've been using this for another project for last couple of weeks, and just today did some benchmarking against the Http one. The following shows the improvements for increasing broadcast size for cold runs. Each line represent the number of receivers.  After the first broadcast is over, i.e., after JVM is wormed up and for HttpBroadcast the server is already running (I think), the following are the improvements for warm runs.  The curves are not as nice as the cold runs, but the improvements are obvious, specially for larger broadcasts and more receivers. Depending on how it goes, we should deprecate and/or remove old TreeBroadcast and BitTorrentBroadcast implementations, and hopefully, SPARK-889 will not be necessary any more. Project: http://git-wip-us.apache.org/repos/asf/incubator-spark/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-spark/commit/e5316d06 Tree: http://git-wip-us.apache.org/repos/asf/incubator-spark/tree/e5316d06 Diff: http://git-wip-us.apache.org/repos/asf/incubator-spark/diff/e5316d06 Branch: refs/heads/master Commit: e5316d0685c41a40e54a064cf271f3d62df6c8e8 Parents: 8d528af 08391db Author: Matei Zaharia <ma...@eecs.berkeley.edu> Authored: Fri Oct 18 20:30:56 2013 -0700 Committer: Matei Zaharia <ma...@eecs.berkeley.edu> Committed: Fri Oct 18 20:30:56 2013 -0700 ---------------------------------------------------------------------- .../spark/broadcast/TorrentBroadcast.scala | 247 +++++++++++++++++++ .../org/apache/spark/storage/BlockId.scala | 9 +- .../org/apache/spark/storage/BlockManager.scala | 5 +- .../spark/storage/BlockManagerMasterActor.scala | 4 +- .../scala/org/apache/spark/BroadcastSuite.scala | 52 +++- docs/configuration.md | 8 + .../apache/spark/examples/BroadcastTest.scala | 15 +- 7 files changed, 328 insertions(+), 12 deletions(-) ----------------------------------------------------------------------
