Updated Branches: refs/heads/sqoop2 d3d52fada -> f3a2c576e
SQOOP-1233. Remove unnecessary explicit call to MessageFormat. (Jarek Jarcec Cecho via Hari Shreedharan) Project: http://git-wip-us.apache.org/repos/asf/sqoop/repo Commit: http://git-wip-us.apache.org/repos/asf/sqoop/commit/f3a2c576 Tree: http://git-wip-us.apache.org/repos/asf/sqoop/tree/f3a2c576 Diff: http://git-wip-us.apache.org/repos/asf/sqoop/diff/f3a2c576 Branch: refs/heads/sqoop2 Commit: f3a2c576ed3cc54745489cdabadd8c3c35782911 Parents: d3d52fa Author: Hari Shreedharan <[email protected]> Authored: Sun Feb 2 20:56:18 2014 -0800 Committer: Hari Shreedharan <[email protected]> Committed: Sun Feb 2 20:56:18 2014 -0800 ---------------------------------------------------------------------- shell/src/main/java/org/apache/sqoop/shell/HelpCommand.java | 8 ++------ .../main/java/org/apache/sqoop/shell/ShellEnvironment.java | 5 ++--- 2 files changed, 4 insertions(+), 9 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/sqoop/blob/f3a2c576/shell/src/main/java/org/apache/sqoop/shell/HelpCommand.java ---------------------------------------------------------------------- diff --git a/shell/src/main/java/org/apache/sqoop/shell/HelpCommand.java b/shell/src/main/java/org/apache/sqoop/shell/HelpCommand.java index e8d531f..3921b10 100644 --- a/shell/src/main/java/org/apache/sqoop/shell/HelpCommand.java +++ b/shell/src/main/java/org/apache/sqoop/shell/HelpCommand.java @@ -107,12 +107,8 @@ public class HelpCommand extends CommandSupport { String description = command.getDescription(); - StringBuilder sb = new StringBuilder(); - sb.append(" ") - .append(MessageFormat.format(resource.getString(Constants - .RES_HELP_CMD_DESCRIPTION), paddedName, - paddedShortcut, description)); - println(sb.toString()); + print(" "); + println(resource.getString(Constants.RES_HELP_CMD_DESCRIPTION), paddedName, paddedShortcut, description); } println(); http://git-wip-us.apache.org/repos/asf/sqoop/blob/f3a2c576/shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java ---------------------------------------------------------------------- diff --git a/shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java b/shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java index 8be2e54..e0924c1 100644 --- a/shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java +++ b/shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java @@ -25,7 +25,6 @@ import org.codehaus.groovy.tools.shell.IO; import java.net.MalformedURLException; import java.net.URL; -import java.text.MessageFormat; import java.util.Locale; import java.util.ResourceBundle; @@ -174,11 +173,11 @@ public final class ShellEnvironment { } public static void printlnResource(String resourceName, Object... values) { - io.out.println(MessageFormat.format(resourceString(resourceName), values)); + io.out.printf(resourceString(resourceName), values); } public static void println(String str, Object ... values) { - io.out.println(MessageFormat.format(str, values)); + io.out.printf(str, values); } public static void println(String str) {
