Repository: sqoop
Updated Branches:
  refs/heads/trunk 268299ee5 -> 57336d7f5


SQOOP-1508: Add warning when using unsupported compression codec

(Qian Xu via Jarek Jarcec Cecho)


Project: http://git-wip-us.apache.org/repos/asf/sqoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/sqoop/commit/57336d7f
Tree: http://git-wip-us.apache.org/repos/asf/sqoop/tree/57336d7f
Diff: http://git-wip-us.apache.org/repos/asf/sqoop/diff/57336d7f

Branch: refs/heads/trunk
Commit: 57336d7f53f073a0728263b04569cf0ffbad9dea
Parents: 268299e
Author: Jarek Jarcec Cecho <[email protected]>
Authored: Thu Sep 11 08:29:41 2014 +0200
Committer: Jarek Jarcec Cecho <[email protected]>
Committed: Thu Sep 11 08:29:41 2014 +0200

----------------------------------------------------------------------
 src/java/org/apache/sqoop/mapreduce/ImportJobBase.java | 12 ++++++++++++
 1 file changed, 12 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/sqoop/blob/57336d7f/src/java/org/apache/sqoop/mapreduce/ImportJobBase.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 
b/src/java/org/apache/sqoop/mapreduce/ImportJobBase.java
index 0ac35de..7b5ed66 100644
--- a/src/java/org/apache/sqoop/mapreduce/ImportJobBase.java
+++ b/src/java/org/apache/sqoop/mapreduce/ImportJobBase.java
@@ -140,6 +140,18 @@ public class ImportJobBase extends JobBase {
             .set(AvroJob.OUTPUT_CODEC, DataFileConstants.DEFLATE_CODEC);
         }
       }
+
+      if (options.getFileLayout() == SqoopOptions.FileLayout.ParquetFile) {
+        if (codecName != null) {
+          Configuration conf = job.getConfiguration();
+          String shortName = CodecMap.getCodecShortNameByName(codecName, conf);
+          if (!shortName.equalsIgnoreCase("default") &&
+              !shortName.equalsIgnoreCase("snappy")) {
+            // TODO: SQOOP-1391 More compression codec support
+            LOG.warn("Will use snappy as compression codec instead");
+          }
+        }
+      }
     }
 
     Path outputPath = context.getDestination();

Reply via email to