Repository: sqoop Updated Branches: refs/heads/sqoop2 c0c9b9ef7 -> d38e239b9
SQOOP-1846: Sqoop2: Update CSVIntermediateFormat DateTime tests to use modified ISO-8601 format (Veena Basavaraj via Abraham Elmahrek) Project: http://git-wip-us.apache.org/repos/asf/sqoop/repo Commit: http://git-wip-us.apache.org/repos/asf/sqoop/commit/d38e239b Tree: http://git-wip-us.apache.org/repos/asf/sqoop/tree/d38e239b Diff: http://git-wip-us.apache.org/repos/asf/sqoop/diff/d38e239b Branch: refs/heads/sqoop2 Commit: d38e239b90a5a08f0b2f4ad7d364696bffe7a93d Parents: c0c9b9e Author: Abraham Elmahrek <[email protected]> Authored: Fri Dec 5 16:52:04 2014 -0800 Committer: Abraham Elmahrek <[email protected]> Committed: Fri Dec 5 16:52:04 2014 -0800 ---------------------------------------------------------------------- .../idf/TestCSVIntermediateDataFormat.java | 22 ++++---------------- 1 file changed, 4 insertions(+), 18 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/sqoop/blob/d38e239b/connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java ---------------------------------------------------------------------- diff --git a/connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java b/connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java index 8a032ef..e66c897 100644 --- a/connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java +++ b/connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestCSVIntermediateDataFormat.java @@ -421,27 +421,13 @@ public class TestCSVIntermediateDataFormat { schema.addColumn(new DateTime("1")); dataFormat.setSchema(schema); dataFormat.setTextData("'2014-10-01 12:00:00.000'"); + org.joda.time.DateTime dateTime = new org.joda.time.DateTime(2014, 10, 01, 12, 0, 0, 0); + assertEquals(dateTime, dataFormat.getObjectData()[0]); + // NOTE: string representation will have the T added, it is an + // implementation quirk of using JODA assertEquals("2014-10-01T12:00:00.000-07:00", dataFormat.getObjectData()[0].toString()); } - /** - * In ISO8601 "T" is used as date-time separator. Unfortunately in the real - * world, database (confirmed with mysql and postgres) might return a datetime - * string with a space as separator. The test case intends to check, whether - * such datetime string can be handled expectedly. - */ - @Test - public void testDateTimeISO8601Alternative() { - Schema schema = new Schema("test"); - schema.addColumn(new DateTime("1")); - dataFormat.setSchema(schema); - - for (String dateTime : new String[] { "'2014-10-01 12:00:00'", "'2014-10-01 12:00:00.000'" }) { - dataFormat.setTextData(dateTime); - assertEquals("2014-10-01T12:00:00.000-07:00", dataFormat.getObjectData()[0].toString()); - } - } - // **************test cases for BIT******************* @Test
