Repository: sqoop
Updated Branches:
  refs/heads/sqoop2 cc78250d6 -> 1fa2d6c0d


SQOOP-1917: Sqoop2: "show connector --all" fails

(Qian Xu via Abraham Elmahrek)


Project: http://git-wip-us.apache.org/repos/asf/sqoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/sqoop/commit/1fa2d6c0
Tree: http://git-wip-us.apache.org/repos/asf/sqoop/tree/1fa2d6c0
Diff: http://git-wip-us.apache.org/repos/asf/sqoop/diff/1fa2d6c0

Branch: refs/heads/sqoop2
Commit: 1fa2d6c0de64a8df2302504e1587a138097fa841
Parents: cc78250
Author: Abraham Elmahrek <[email protected]>
Authored: Wed Dec 17 09:58:42 2014 -0800
Committer: Abraham Elmahrek <[email protected]>
Committed: Wed Dec 17 10:12:10 2014 -0800

----------------------------------------------------------------------
 .../apache/sqoop/shell/utils/ConfigDisplayer.java  | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/sqoop/blob/1fa2d6c0/shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java
----------------------------------------------------------------------
diff --git 
a/shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java 
b/shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java
index 2bba4cf..e240163 100644
--- a/shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java
+++ b/shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java
@@ -62,15 +62,14 @@ public final class ConfigDisplayer {
         resourceString(Constants.RES_CONFIG_DISPLAYER_LINK),
         bundle);
 
-    displayConfig(
-        connector.getConfig(Direction.FROM).getConfigs(),
-        Direction.FROM.toString() + " " + 
resourceString(Constants.RES_CONFIG_DISPLAYER_JOB),
-        bundle);
-
-    displayConfig(
-        connector.getConfig(Direction.TO).getConfigs(),
-        Direction.TO.toString() + " " + 
resourceString(Constants.RES_CONFIG_DISPLAYER_JOB),
-        bundle);
+    for (Direction direction : new Direction[] {Direction.FROM, Direction.TO}) 
{
+      if (connector.getSupportedDirections().isDirectionSupported(direction)) {
+        displayConfig(
+            connector.getConfig(direction).getConfigs(),
+            direction.toString() + " " + 
resourceString(Constants.RES_CONFIG_DISPLAYER_JOB),
+            bundle);
+      }
+    }
   }
 
    private static void displayConfig(List<MConfig> configs,

Reply via email to