Repository: sqoop Updated Branches: refs/heads/sqoop2 7d05cc28f -> a13343b34
SQOOP-2555: Sqoop2: Findbugs: Add filter for the unnecessary warning (Colin Ma via Jarek Jarcec Cecho) Project: http://git-wip-us.apache.org/repos/asf/sqoop/repo Commit: http://git-wip-us.apache.org/repos/asf/sqoop/commit/a13343b3 Tree: http://git-wip-us.apache.org/repos/asf/sqoop/tree/a13343b3 Diff: http://git-wip-us.apache.org/repos/asf/sqoop/diff/a13343b3 Branch: refs/heads/sqoop2 Commit: a13343b34536e6ea79253ecece29ad61124802b7 Parents: 7d05cc2 Author: Jarek Jarcec Cecho <[email protected]> Authored: Tue Sep 8 12:27:34 2015 +0200 Committer: Jarek Jarcec Cecho <[email protected]> Committed: Tue Sep 8 12:27:34 2015 +0200 ---------------------------------------------------------------------- connector/connector-kite/pom.xml | 4 ++++ .../org/apache/sqoop/connector/kite/KiteDatasetExecutor.java | 1 + connector/connector-sdk/pom.xml | 4 ++++ .../java/org/apache/sqoop/connector/common/SqoopIDFUtils.java | 1 + .../apache/sqoop/connector/idf/AVROIntermediateDataFormat.java | 1 + .../apache/sqoop/connector/idf/JSONIntermediateDataFormat.java | 1 + core/pom.xml | 4 ++++ .../org/apache/sqoop/core/PropertiesConfigurationProvider.java | 1 + .../src/main/java/org/apache/sqoop/core/SqoopConfiguration.java | 1 + core/src/main/java/org/apache/sqoop/driver/JobManager.java | 1 + .../org/apache/sqoop/repository/JdbcRepositoryProvider.java | 2 +- execution/mapreduce/pom.xml | 5 ++++- .../org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java | 1 + server/pom.xml | 4 ++++ .../main/java/org/apache/sqoop/server/ServerInitializer.java | 1 + shell/pom.xml | 4 ++++ .../main/java/org/apache/sqoop/shell/ShowVersionFunction.java | 1 + 17 files changed, 35 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/sqoop/blob/a13343b3/connector/connector-kite/pom.xml ---------------------------------------------------------------------- diff --git a/connector/connector-kite/pom.xml b/connector/connector-kite/pom.xml index 41441f5..ff3e0c8 100644 --- a/connector/connector-kite/pom.xml +++ b/connector/connector-kite/pom.xml @@ -71,6 +71,10 @@ limitations under the License. <artifactId>powermock-api-mockito</artifactId> <scope>test</scope> </dependency> + <dependency> + <groupId>net.sourceforge.findbugs</groupId> + <artifactId>annotations</artifactId> + </dependency> <!-- Kite required modules --> <dependency> http://git-wip-us.apache.org/repos/asf/sqoop/blob/a13343b3/connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetExecutor.java ---------------------------------------------------------------------- diff --git a/connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetExecutor.java b/connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetExecutor.java index 6aa28be..0f77964 100644 --- a/connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetExecutor.java +++ b/connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetExecutor.java @@ -47,6 +47,7 @@ import java.util.UUID; * The class arranges to perform dataset operations (without thread safety * guarantee). */ [email protected]("PZLA_PREFER_ZERO_LENGTH_ARRAYS") public class KiteDatasetExecutor { private final Dataset<GenericRecord> dataset; http://git-wip-us.apache.org/repos/asf/sqoop/blob/a13343b3/connector/connector-sdk/pom.xml ---------------------------------------------------------------------- diff --git a/connector/connector-sdk/pom.xml b/connector/connector-sdk/pom.xml index c888aa0..5e20713 100644 --- a/connector/connector-sdk/pom.xml +++ b/connector/connector-sdk/pom.xml @@ -53,6 +53,10 @@ limitations under the License. <groupId>org.apache.avro</groupId> <artifactId>avro</artifactId> </dependency> + <dependency> + <groupId>net.sourceforge.findbugs</groupId> + <artifactId>annotations</artifactId> + </dependency> </dependencies> </project> http://git-wip-us.apache.org/repos/asf/sqoop/blob/a13343b3/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java ---------------------------------------------------------------------- diff --git a/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java b/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java index 52ff2b8..9b0885a 100644 --- a/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java +++ b/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java @@ -60,6 +60,7 @@ import java.util.Collections; */ @InterfaceAudience.Public @InterfaceStability.Unstable [email protected]("PZLA_PREFER_ZERO_LENGTH_ARRAYS") public class SqoopIDFUtils { public static final String NULL_VALUE = "NULL"; http://git-wip-us.apache.org/repos/asf/sqoop/blob/a13343b3/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java ---------------------------------------------------------------------- diff --git a/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java b/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java index 68eb6eb..d78fa8b 100644 --- a/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java +++ b/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java @@ -59,6 +59,7 @@ import java.util.Set; */ @InterfaceAudience.Public @InterfaceStability.Unstable [email protected]("PZLA_PREFER_ZERO_LENGTH_ARRAYS") public class AVROIntermediateDataFormat extends IntermediateDataFormat<GenericRecord> { private Schema avroSchema; http://git-wip-us.apache.org/repos/asf/sqoop/blob/a13343b3/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java ---------------------------------------------------------------------- diff --git a/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java b/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java index 9708c05..8db4d3d 100644 --- a/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java +++ b/connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java @@ -46,6 +46,7 @@ import java.util.Set; */ @InterfaceAudience.Public @InterfaceStability.Unstable [email protected]("PZLA_PREFER_ZERO_LENGTH_ARRAYS") public class JSONIntermediateDataFormat extends IntermediateDataFormat<JSONObject> { // need this default constructor for reflection magic used in execution engine http://git-wip-us.apache.org/repos/asf/sqoop/blob/a13343b3/core/pom.xml ---------------------------------------------------------------------- diff --git a/core/pom.xml b/core/pom.xml index 0a8ec09..f749890 100644 --- a/core/pom.xml +++ b/core/pom.xml @@ -57,6 +57,10 @@ limitations under the License. <groupId>org.apache.sqoop</groupId> <artifactId>connector-sdk</artifactId> </dependency> + <dependency> + <groupId>net.sourceforge.findbugs</groupId> + <artifactId>annotations</artifactId> + </dependency> </dependencies> <build> http://git-wip-us.apache.org/repos/asf/sqoop/blob/a13343b3/core/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider.java b/core/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider.java index 2e2d068..7b06152 100644 --- a/core/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider.java +++ b/core/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider.java @@ -35,6 +35,7 @@ import org.apache.sqoop.error.code.CoreError; import static org.apache.sqoop.core.ConfigurationConstants.PROPERTIES_PROVIDER_SLEEP; [email protected]("IS2_INCONSISTENT_SYNC") public class PropertiesConfigurationProvider implements ConfigurationProvider { private static final Logger LOG = http://git-wip-us.apache.org/repos/asf/sqoop/blob/a13343b3/core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java b/core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java index 8f9c445..04da05f 100644 --- a/core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java +++ b/core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java @@ -46,6 +46,7 @@ import static org.apache.sqoop.utils.ContextUtils.getUniqueStrings; */ @InterfaceAudience.Public @InterfaceStability.Unstable [email protected]("IS2_INCONSISTENT_SYNC") public class SqoopConfiguration implements Reconfigurable { /** http://git-wip-us.apache.org/repos/asf/sqoop/blob/a13343b3/core/src/main/java/org/apache/sqoop/driver/JobManager.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/sqoop/driver/JobManager.java b/core/src/main/java/org/apache/sqoop/driver/JobManager.java index 44416c4..fdd48f1 100644 --- a/core/src/main/java/org/apache/sqoop/driver/JobManager.java +++ b/core/src/main/java/org/apache/sqoop/driver/JobManager.java @@ -51,6 +51,7 @@ import org.apache.sqoop.schema.Schema; import org.apache.sqoop.submission.SubmissionStatus; import org.apache.sqoop.utils.ClassUtils; [email protected]("IS2_INCONSISTENT_SYNC") public class JobManager implements Reconfigurable { /** * Logger object. http://git-wip-us.apache.org/repos/asf/sqoop/blob/a13343b3/core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java ---------------------------------------------------------------------- diff --git a/core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java b/core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java index 011527f..1e0e31d 100644 --- a/core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java +++ b/core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java @@ -37,7 +37,7 @@ import org.apache.sqoop.common.MapContext; import org.apache.sqoop.core.SqoopConfiguration; import org.apache.sqoop.utils.ClassUtils; - [email protected]("IS2_INCONSISTENT_SYNC") public class JdbcRepositoryProvider implements RepositoryProvider { private static final Logger LOG = Logger.getLogger(JdbcRepositoryProvider.class); http://git-wip-us.apache.org/repos/asf/sqoop/blob/a13343b3/execution/mapreduce/pom.xml ---------------------------------------------------------------------- diff --git a/execution/mapreduce/pom.xml b/execution/mapreduce/pom.xml index 814f2ce..4fc3046 100644 --- a/execution/mapreduce/pom.xml +++ b/execution/mapreduce/pom.xml @@ -72,7 +72,10 @@ limitations under the License. <groupId>com.google.guava</groupId> <artifactId>guava</artifactId> </dependency> - + <dependency> + <groupId>net.sourceforge.findbugs</groupId> + <artifactId>annotations</artifactId> + </dependency> <!-- See profiles for Hadoop specific dependencies --> </dependencies> http://git-wip-us.apache.org/repos/asf/sqoop/blob/a13343b3/execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java ---------------------------------------------------------------------- diff --git a/execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java b/execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java index c9d6f10..d94b658 100644 --- a/execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java +++ b/execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java @@ -46,6 +46,7 @@ import org.apache.sqoop.submission.counter.SqoopCounters; import org.apache.sqoop.job.io.SqoopWritable; import org.apache.sqoop.utils.ClassUtils; [email protected]("PZLA_PREFER_ZERO_LENGTH_ARRAYS") public class SqoopOutputFormatLoadExecutor { public static final Logger LOG = http://git-wip-us.apache.org/repos/asf/sqoop/blob/a13343b3/server/pom.xml ---------------------------------------------------------------------- diff --git a/server/pom.xml b/server/pom.xml index 59663fa..53307f8 100644 --- a/server/pom.xml +++ b/server/pom.xml @@ -132,6 +132,10 @@ limitations under the License. <groupId>com.googlecode.json-simple</groupId> <artifactId>json-simple</artifactId> </dependency> + <dependency> + <groupId>net.sourceforge.findbugs</groupId> + <artifactId>annotations</artifactId> + </dependency> </dependencies> <build> http://git-wip-us.apache.org/repos/asf/sqoop/blob/a13343b3/server/src/main/java/org/apache/sqoop/server/ServerInitializer.java ---------------------------------------------------------------------- diff --git a/server/src/main/java/org/apache/sqoop/server/ServerInitializer.java b/server/src/main/java/org/apache/sqoop/server/ServerInitializer.java index 48963f3..70bb6ee 100644 --- a/server/src/main/java/org/apache/sqoop/server/ServerInitializer.java +++ b/server/src/main/java/org/apache/sqoop/server/ServerInitializer.java @@ -28,6 +28,7 @@ import javax.servlet.ServletContextListener; * Initializes the Sqoop server. This listener is also responsible for * cleaning up any resources occupied by the server during the system shutdown. */ [email protected]("DM_EXIT") public class ServerInitializer implements ServletContextListener { private static final Logger LOG = Logger.getLogger(ServerInitializer.class); http://git-wip-us.apache.org/repos/asf/sqoop/blob/a13343b3/shell/pom.xml ---------------------------------------------------------------------- diff --git a/shell/pom.xml b/shell/pom.xml index a699f71..f54160f 100644 --- a/shell/pom.xml +++ b/shell/pom.xml @@ -76,6 +76,10 @@ limitations under the License. <artifactId>groovy-all</artifactId> <version>1.8.5</version> </dependency> + <dependency> + <groupId>net.sourceforge.findbugs</groupId> + <artifactId>annotations</artifactId> + </dependency> </dependencies> <profiles> http://git-wip-us.apache.org/repos/asf/sqoop/blob/a13343b3/shell/src/main/java/org/apache/sqoop/shell/ShowVersionFunction.java ---------------------------------------------------------------------- diff --git a/shell/src/main/java/org/apache/sqoop/shell/ShowVersionFunction.java b/shell/src/main/java/org/apache/sqoop/shell/ShowVersionFunction.java index 28d5de7..16452b5 100644 --- a/shell/src/main/java/org/apache/sqoop/shell/ShowVersionFunction.java +++ b/shell/src/main/java/org/apache/sqoop/shell/ShowVersionFunction.java @@ -30,6 +30,7 @@ import org.apache.sqoop.validation.Status; import static org.apache.sqoop.shell.ShellEnvironment.*; @SuppressWarnings("serial") [email protected]("SE_BAD_FIELD") public class ShowVersionFunction extends SqoopFunction { private static final long serialVersionUID = 1L; private VersionResourceRequest versionRequest;
