Repository: sqoop Updated Branches: refs/heads/trunk 68f76982a -> 7d6667ddb
SQOOP-2990: Sqoop(oracle) export [updateTableToOracle] with "--update-mode allowinsert" : app fails with java.sql.SQLException: Missing IN or OUT parameter at index (Sowmya Ramesh via Venkat Ranganathan) Project: http://git-wip-us.apache.org/repos/asf/sqoop/repo Commit: http://git-wip-us.apache.org/repos/asf/sqoop/commit/7d6667dd Tree: http://git-wip-us.apache.org/repos/asf/sqoop/tree/7d6667dd Diff: http://git-wip-us.apache.org/repos/asf/sqoop/diff/7d6667dd Branch: refs/heads/trunk Commit: 7d6667ddb65ff1e5c5ff2c4b764a8b3996016bf1 Parents: 68f7698 Author: Venkat Ranganathan <[email protected]> Authored: Fri Nov 11 14:06:21 2016 -0800 Committer: Venkat Ranganathan <[email protected]> Committed: Fri Nov 11 14:06:21 2016 -0800 ---------------------------------------------------------------------- .../org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/sqoop/blob/7d6667dd/src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java ---------------------------------------------------------------------- diff --git a/src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java b/src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java index f79aaa9..88754e7 100644 --- a/src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java +++ b/src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java @@ -71,7 +71,7 @@ public class OracleUpsertOutputFormat<K extends SqoopRecord, V> // lookup table for update columns Set<String> updateKeyLookup = new LinkedHashSet<String>(); for (String updateKey : updateCols) { - updateKeyLookup.add(updateKey); + updateKeyLookup.add('"' + updateKey + '"'); } StringBuilder sb = new StringBuilder(); @@ -85,7 +85,7 @@ public class OracleUpsertOutputFormat<K extends SqoopRecord, V> } else { sb.append(" AND "); } - sb.append(updateCols[i]).append(" = ?"); + sb.append('"' + updateCols[i] + '"').append(" = ?"); } sb.append(" )");
