lock down methods that don't need to be public
Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/11b01518 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/11b01518 Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/11b01518 Branch: refs/heads/master Commit: 11b01518f0935dedfd71d09b697d7189a29b91b5 Parents: df34930 Author: P. Taylor Goetz <ptgo...@gmail.com> Authored: Thu Apr 2 00:08:12 2015 -0400 Committer: P. Taylor Goetz <ptgo...@gmail.com> Committed: Thu Apr 2 00:08:12 2015 -0400 ---------------------------------------------------------------------- .../main/java/org/apache/storm/flux/FluxBuilder.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/storm/blob/11b01518/flux-core/src/main/java/org/apache/storm/flux/FluxBuilder.java ---------------------------------------------------------------------- diff --git a/flux-core/src/main/java/org/apache/storm/flux/FluxBuilder.java b/flux-core/src/main/java/org/apache/storm/flux/FluxBuilder.java index 31b6e64..964c62e 100644 --- a/flux-core/src/main/java/org/apache/storm/flux/FluxBuilder.java +++ b/flux-core/src/main/java/org/apache/storm/flux/FluxBuilder.java @@ -61,7 +61,7 @@ public class FluxBuilder { * @throws NoSuchMethodException * @throws InvocationTargetException */ - public static StormTopology buildTopology(ExecutionContext context) throws IllegalAccessException, + static StormTopology buildTopology(ExecutionContext context) throws IllegalAccessException, InstantiationException, ClassNotFoundException, NoSuchMethodException, InvocationTargetException { StormTopology topology = null; @@ -206,7 +206,7 @@ public class FluxBuilder { } } - public static void applyProperties(ObjectDef bean, Object instance, ExecutionContext context) throws + private static void applyProperties(ObjectDef bean, Object instance, ExecutionContext context) throws IllegalAccessException, InvocationTargetException { List<PropertyDef> props = bean.getProperties(); Class clazz = instance.getClass(); @@ -230,7 +230,7 @@ public class FluxBuilder { } } - public static Field findPublicField(Class clazz, String property, Object arg) { + private static Field findPublicField(Class clazz, String property, Object arg) { Field field = null; try { field = clazz.getField(property); @@ -240,7 +240,7 @@ public class FluxBuilder { return field; } - public static Method findSetter(Class clazz, String property, Object arg) { + private static Method findSetter(Class clazz, String property, Object arg) { String setterName = toSetterName(property); Method retval = null; Method[] methods = clazz.getMethods(); @@ -253,11 +253,11 @@ public class FluxBuilder { return retval; } - public static String toSetterName(String name) { + private static String toSetterName(String name) { return "set" + name.substring(0, 1).toUpperCase() + name.substring(1, name.length()); } - public static List<Object> resolveReferences(List<Object> args, ExecutionContext context) { + private static List<Object> resolveReferences(List<Object> args, ExecutionContext context) { LOG.debug("Checking arguments for references."); List<Object> cArgs = new ArrayList<Object>(); // resolve references
