Repository: storm Updated Branches: refs/heads/1.0.x-branch 52875c24c -> 9cf6ebc60
STORM-1756: Explicitly null KafkaServer reference in KafkaTestBroker to prevent out of memory on large test classes Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/1e873f71 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/1e873f71 Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/1e873f71 Branch: refs/heads/1.0.x-branch Commit: 1e873f71d7f52bab689d780773c51eebaf9f4c09 Parents: 52875c2 Author: Stig Rohde Døssing <[email protected]> Authored: Mon May 2 15:07:07 2016 +0200 Committer: Jungtaek Lim <[email protected]> Committed: Mon May 16 18:01:57 2016 +0900 ---------------------------------------------------------------------- .../src/test/org/apache/storm/kafka/KafkaTestBroker.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/storm/blob/1e873f71/external/storm-kafka/src/test/org/apache/storm/kafka/KafkaTestBroker.java ---------------------------------------------------------------------- diff --git a/external/storm-kafka/src/test/org/apache/storm/kafka/KafkaTestBroker.java b/external/storm-kafka/src/test/org/apache/storm/kafka/KafkaTestBroker.java index e2fb60f..90c56e6 100644 --- a/external/storm-kafka/src/test/org/apache/storm/kafka/KafkaTestBroker.java +++ b/external/storm-kafka/src/test/org/apache/storm/kafka/KafkaTestBroker.java @@ -78,7 +78,12 @@ public class KafkaTestBroker { return port; } public void shutdown() { - kafka.shutdown(); + if (kafka != null) { + kafka.shutdown(); + kafka.awaitShutdown(); + } + //Ensure kafka server is eligible for garbage collection immediately + kafka = null; if (zookeeper.getState().equals(CuratorFrameworkState.STARTED)) { zookeeper.close(); }
