[1/2] storm git commit: [STORM-2643] add confirmation before profiling/debugging actions

[xinwang]

Repository: storm
Updated Branches:
  refs/heads/master e38f93607 -> 12b06df72


[STORM-2643] add confirmation before profiling/debugging actions


Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/c2d8e774
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/c2d8e774
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/c2d8e774

Branch: refs/heads/master
Commit: c2d8e77495f1970d716a2e91e2afa20abd438a8c
Parents: 8814bfa
Author: Ethan Li <ethanopensou...@gmail.com>
Authored: Wed Jul 19 10:06:44 2017 -0500
Committer: Ethan Li <ethanopensou...@gmail.com>
Committed: Wed Jul 19 19:07:01 2017 -0500

----------------------------------------------------------------------
 storm-core/src/ui/public/component.html | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/storm/blob/c2d8e774/storm-core/src/ui/public/component.html
----------------------------------------------------------------------
diff --git a/storm-core/src/ui/public/component.html 
b/storm-core/src/ui/public/component.html
index bd0f9b4..b2a2ca2 100644
--- a/storm-core/src/ui/public/component.html
+++ b/storm-core/src/ui/public/component.html
@@ -357,6 +357,7 @@ $(document).ready(function() {
 getPageRenderedTimestamp("page-rendered-at-timestamp");
 
 function start_profiling() {
+    if (!confirmAction("start profiling")) return false;
     var topologyId = $.url("?topology_id");
     var timeout = $("#timeout").val();
 
@@ -405,6 +406,7 @@ function start_profiling() {
 }
 
 function stop_profiling(id) {
+    if (!confirmAction("stop profiling")) return false;
     var topologyId = $.url("?topology_id");
     var url = "/api/v1/topology/"+topologyId+"/profiling/stop/" + id;
 
@@ -421,6 +423,7 @@ function stop_profiling(id) {
 }
 
 function dump_profile(id) {
+    if (!confirmAction("dump profile")) return false;
     var topologyId = $.url("?topology_id");
     var url = "/api/v1/topology/"+topologyId+"/profiling/dumpprofile/" + id;
 
@@ -437,8 +440,8 @@ function dump_profile(id) {
 
 // Create jstack output for all selected workers.
 function dump_jstacks() {
+    if (!confirmAction("dump jstack")) return false;
     var topologyId = $.url("?topology_id");
-
     var failed = {}
     var passed = {}
     Object.keys(workerActionSelected).forEach(function (id) {
@@ -465,6 +468,7 @@ function dump_jstacks() {
 
 // Create jstack output for the worker with the given id.
 function dump_jstack(id) {
+    if (!confirmAction("dump jstack")) return false;
     var topologyId = $.url("?topology_id");
     var url = "/api/v1/topology/"+topologyId+"/profiling/dumpjstack/" + id;
 
@@ -480,6 +484,7 @@ function dump_jstack(id) {
 }
 
 function restart_worker_jvms() {
+    if (!confirmAction("restart worker")) return false;
     var topologyId = $.url("?topology_id");
     var failed = {}
     var passed = {}
@@ -507,6 +512,7 @@ function restart_worker_jvms() {
 
 // Create java heap output for all selected workers.
 function dump_heaps() {
+    if (!confirmAction("dump heap")) return false;
     var topologyId = $.url("?topology_id");
     var failed = {}
     var passed = {}
@@ -534,6 +540,7 @@ function dump_heaps() {
 
 // Create java heap output for the worker with the given id.
 function dump_heap(id) {
+    if (!confirmAction("dump heap")) return false;
     var topologyId = $.url("?topology_id");
     var url = "/api/v1/topology/"+topologyId+"/profiling/dumpheap/" + id;
     var heap = $("#dump_heap_" + id);
@@ -548,6 +555,11 @@ function dump_heap(id) {
     });
 }
 
+// Confirm an action
+function confirmAction(actionText){
+    return confirm('Do you really want to ' + actionText + '?');
+}
+
 </script>
 </div>
 </body>