Repository: storm Updated Branches: refs/heads/master 0bf7e703f -> d16ed4cb5
STORM-2705: DRPCSpout should not sleep itself if no request was fetched as the ISpoutWaitStrategy handles this case. Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/954d158b Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/954d158b Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/954d158b Branch: refs/heads/master Commit: 954d158bff04c8bdc638429fc1ca2a78a773d696 Parents: 0bf7e70 Author: sakanaou <[email protected]> Authored: Thu Aug 24 09:58:42 2017 +0200 Committer: sakanaou <[email protected]> Committed: Thu Aug 24 09:58:42 2017 +0200 ---------------------------------------------------------------------- storm-client/src/jvm/org/apache/storm/drpc/DRPCSpout.java | 6 ------ 1 file changed, 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/storm/blob/954d158b/storm-client/src/jvm/org/apache/storm/drpc/DRPCSpout.java ---------------------------------------------------------------------- diff --git a/storm-client/src/jvm/org/apache/storm/drpc/DRPCSpout.java b/storm-client/src/jvm/org/apache/storm/drpc/DRPCSpout.java index b36b7c1..8605c05 100644 --- a/storm-client/src/jvm/org/apache/storm/drpc/DRPCSpout.java +++ b/storm-client/src/jvm/org/apache/storm/drpc/DRPCSpout.java @@ -186,7 +186,6 @@ public class DRPCSpout extends BaseRichSpout { @Override public void nextTuple() { - boolean gotRequest = false; if(_local_drpc_id==null) { int size = 0; synchronized (_clients) { @@ -209,7 +208,6 @@ public class DRPCSpout extends BaseRichSpout { returnInfo.put("id", req.get_request_id()); returnInfo.put("host", client.getHost()); returnInfo.put("port", client.getPort()); - gotRequest = true; _collector.emit(new Values(req.get_func_args(), JSONValue.toJSONString(returnInfo)), new DRPCMessageId(req.get_request_id(), i)); break; } @@ -234,7 +232,6 @@ public class DRPCSpout extends BaseRichSpout { returnInfo.put("id", req.get_request_id()); returnInfo.put("host", _local_drpc_id); returnInfo.put("port", 0); - gotRequest = true; _collector.emit(new Values(req.get_func_args(), JSONValue.toJSONString(returnInfo)), new DRPCMessageId(req.get_request_id(), 0)); } @@ -245,9 +242,6 @@ public class DRPCSpout extends BaseRichSpout { } } } - if(!gotRequest) { - Utils.sleep(1); - } } @Override
