Repository: storm Updated Branches: refs/heads/master 4b2d6dc32 -> cbe1e372a
[STORM-2769] Fast-fail if output streamId is null Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/e20394f9 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/e20394f9 Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/e20394f9 Branch: refs/heads/master Commit: e20394f91246b9d936f8ef3bf130343d7c4f1a03 Parents: c607d04 Author: Ethan Li <[email protected]> Authored: Tue Oct 3 13:54:18 2017 -0500 Committer: Ethan Li <[email protected]> Committed: Tue Oct 3 15:03:16 2017 -0500 ---------------------------------------------------------------------- .../src/jvm/org/apache/storm/topology/OutputFieldsGetter.java | 3 +++ 1 file changed, 3 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/storm/blob/e20394f9/storm-client/src/jvm/org/apache/storm/topology/OutputFieldsGetter.java ---------------------------------------------------------------------- diff --git a/storm-client/src/jvm/org/apache/storm/topology/OutputFieldsGetter.java b/storm-client/src/jvm/org/apache/storm/topology/OutputFieldsGetter.java index abc939c..fa4ca84 100644 --- a/storm-client/src/jvm/org/apache/storm/topology/OutputFieldsGetter.java +++ b/storm-client/src/jvm/org/apache/storm/topology/OutputFieldsGetter.java @@ -39,6 +39,9 @@ public class OutputFieldsGetter implements OutputFieldsDeclarer { } public void declareStream(String streamId, boolean direct, Fields fields) { + if (null == streamId) { + throw new IllegalArgumentException("streamId can't be null"); + } if(_fields.containsKey(streamId)) { throw new IllegalArgumentException("Fields for " + streamId + " already set"); }
