Repository: storm Updated Branches: refs/heads/1.x-branch 79626398f -> b24f5d87c
MINOR: Use booleans instead of strings for 'enable.auto.commit' setting Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/b24f5d87 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/b24f5d87 Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/b24f5d87 Branch: refs/heads/1.x-branch Commit: b24f5d87cbcd4faeed651e45a8e673db52469a46 Parents: 7962639 Author: Stig Rohde Døssing <[email protected]> Authored: Sun Nov 19 11:00:37 2017 +0100 Committer: Stig Rohde Døssing <[email protected]> Committed: Mon Nov 20 21:01:05 2017 +0100 ---------------------------------------------------------------------- .../main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java | 4 ++-- .../java/org/apache/storm/kafka/spout/KafkaSpoutConfigTest.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/storm/blob/b24f5d87/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java ---------------------------------------------------------------------- diff --git a/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java b/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java index 58d4753..ffefa29 100644 --- a/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java +++ b/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java @@ -726,7 +726,7 @@ public class KafkaSpoutConfig<K, V> implements Serializable { } } if (builder.processingGuarantee == ProcessingGuarantee.NONE) { - builder.kafkaProps.put(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG, "true"); + builder.kafkaProps.put(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG, true); } else { String autoOffsetResetPolicy = (String)builder.kafkaProps.get(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG); if (builder.processingGuarantee == ProcessingGuarantee.AT_LEAST_ONCE) { @@ -749,7 +749,7 @@ public class KafkaSpoutConfig<K, V> implements Serializable { + " Some messages may be processed more than once."); } } - builder.kafkaProps.put(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG, "false"); + builder.kafkaProps.put(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG, false); } } http://git-wip-us.apache.org/repos/asf/storm/blob/b24f5d87/external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutConfigTest.java ---------------------------------------------------------------------- diff --git a/external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutConfigTest.java b/external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutConfigTest.java index 59135e4..794bed4 100644 --- a/external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutConfigTest.java +++ b/external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutConfigTest.java @@ -40,7 +40,7 @@ public class KafkaSpoutConfigTest { assertTrue(conf.getTranslator() instanceof DefaultRecordTranslator); HashMap<String, Object> expected = new HashMap<>(); expected.put(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, "localhost:1234"); - expected.put(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG, "false"); + expected.put(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG, false); expected.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, "earliest"); expected.put(ConsumerConfig.KEY_DESERIALIZER_CLASS_CONFIG, StringDeserializer.class); expected.put(ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG, StringDeserializer.class);
